Set catalog min-width at minimum shrinkable width of its ui child elements #3761
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
|
/retest |
rhamilto
reviewed
Dec 12, 2019
sg00dwin
force-pushed
the
catalog-overlap-issue
branch
2 times, most recently
from
c084898
to
e6b580a
Compare
|
/retest |
sg00dwin
force-pushed
the
catalog-overlap-issue
branch
from
e6b580a
to
4f0d36a
Compare
sg00dwin
force-pushed
the
catalog-overlap-issue
branch
from
4f0d36a
to
6164c81
Compare
openshift-ci-robot
added
lgtm
jcaianirh
approved these changes
Dec 17, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spadgett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both Admin and Dev Catalogs
Set the minimum width 590px (575 mobile) that the catalog container can shrink based on the widths needed for its child elements.
Note: horizontal scroll below this width is allowed, based on the UI designs. We should give consideration of a collapse filter list which would alleviate that issue. https://www.patternfly.org/v4/documentation/react/experimental/drawer
Before
After
