New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1782811: Let server do validation of PVC name #3775
Bug 1782811: Let server do validation of PVC name #3775
Conversation
@spadgett: This pull request references Bugzilla bug 1782811, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This avoids a vague error message when the pattern doesn't match and is in line with how other forms work in console. Also mark the request size input required.
4e14135
to
469a1b5
Compare
@spadgett: This pull request references Bugzilla bug 1782811, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
@openshift-bot: This pull request references Bugzilla bug 1782811, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1782811 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This avoids a vague error message when the pattern doesn't match and is in line with how other forms work in console.
Also mark the request size input required.
/assign @zherman0 @rhamilto