Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic pipeline test #3813

Merged
merged 1 commit into from Jan 10, 2020
Merged

Basic pipeline test #3813

merged 1 commit into from Jan 10, 2020

Conversation

sanketpathak
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2019
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Dec 19, 2019
@sanketpathak
Copy link
Contributor Author

/assign @christianvogt

ldimaggi
ldimaggi reviewed Dec 19, 2019
View reviewed changes
frontend/packages/dev-console/integration-tests/tests/pipeline.scenario.ts Outdated
expect(createPipelineYamlError.isPresent()).toBe(false);
await browser.wait(until.visibilityOf(pipelineOverviewName));
expect(pipelineOverviewName.getText()).toContain('new-pipeline');
await execSync(`oc create -f ./packages/dev-console/integration-tests/views/simple-pipeline-demo.yaml`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing from the pull request.

simple-pipeline-demo.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added now thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - now the test runs cleanly for me - thx!

@sanketpathak sanketpathak force-pushed the test-pipeline branch 2 times, most recently from 9e398a1 to 53f1a2c Compare December 19, 2019 20:46
@ldimaggi
Copy link
Contributor

lgtm (as soon as all the tests are passing ;-)

@andrewballantyne
Copy link
Contributor

So, I don't know a ton about running the protractor tests... I thought I needed to make my Chromedriver be the version of my Chrome installed (mac setup; so I can't install a separate instance). But I can't seem to get webdriver-manager to update to Chrome 79.

Any assistance would be appreciated. I have some questions about the script but I don't have anyway to test my theories :)

@christianvogt
Copy link
Contributor

yarn webdriver-update --versions.chrome=<your chrome version>

Get the version from Chrome => About menu

@sanketpathak
Copy link
Contributor Author

/test analyze

@sanketpathak
Copy link
Contributor Author

/test frontend
/test e2e-gcp-console

@andrewballantyne
Copy link
Contributor

@sanketpathak You'll want to run yarn lint in the frontend directory. You're failing several lints.

@andrewballantyne
Copy link
Contributor

I can't seem to run these tests...

If I try to run all of the tests, it freezes and then fails on pod delete.
$ yarn test-gui

1) Kubernetes resource CRUD operations Pod : deletes the resource instance
   Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

If I try to run just devconsole, it fails on git import flow

$ yarn run test-suite --suite "devconsole" --params.openshift true

1) git import flow : public git normal flow
   NoSuchElementError: No element found using locator: By(css selector, *[id="form-input-application-name-field"])

If I redirect all tests to just Pipeline by changing the package.json to point at specifically the Pipeline scenario:

  "consolePlugin": {
    "entry": "src/plugin.tsx",
    "integrationTestSuites": {
      "devconsole": [
        "integration-tests/**/pipeline.scenario.ts"
      ]
    }
  }

$ yarn run test-suite --suite "devconsole" --params.openshift true

I get this error:

1) Pipeline : displays subscription creation form for selected Operator
   NoSuchElementError: No element found using locator: By(link text, Install)

Clearly something is up with my environment. I'll have to debug this with someone from QE late Dec / next year. I'm off next week, but I can't validate this PR so I am not comfortable approving it.

@sanketpathak
Copy link
Contributor Author

sanketpathak commented Dec 23, 2019 •
edited

@andrewballantyne I think you are testing in a cluster where pipeline operator is already installed, so you are getting this error.

1) Pipeline : displays subscription creation form for selected Operator
   NoSuchElementError: No element found using locator: By(link text, Install)

We can debug this if you still get any error while running the tests once you are back

@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

3 similar comments
@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor Author

sanketpathak commented Dec 26, 2019 •
edited

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

@andrewballantyne
Copy link
Contributor

I tried running this again... no luck. It seemed to get further down the line but failed an assertion.

@sanketpathak Perhaps we just need to go over this on bluejeans where you show me the tests pass. I hope it's just me, but we definitely don't need a test that fails sneaking it's way into the e2e tests for all PRs.

@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor Author

sanketpathak commented Jan 6, 2020 •
edited

/test analyze

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 6, 2020 •
edited

@sanketpathak Per our testing of your Pipeline, these are changes needed:

  • The operator name has dots instead of spaces
  • expects at the end of the test don't actually do anything (update tests to properly test for the existence of the pipelines created)
  • the execSync doesn't execute in the test namespace (update to oc create ... -n <namespace>)

@sanketpathak
Copy link
Contributor Author

/test analyze

@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

andrewballantyne
andrewballantyne approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works pretty good. My only concern is the still the roll of the dice to getting the operator installed. It's highly dependant on other operators / number of namespaces.

@andrewballantyne
Copy link
Contributor

/lgtm

I cannot give an approval due to the frontend folder change.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@sanketpathak
Copy link
Contributor Author

/test analyze

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b6c21b into openshift:master Jan 10, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldimaggi ldimaggi ldimaggi left review comments

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

Assignees

@andrewballantyne andrewballantyne

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sanketpathak @ldimaggi @andrewballantyne @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot