Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noobaa Operators Page remaining stuffs #3818

Merged
merged 1 commit into from Jan 21, 2020
Merged

Noobaa Operators Page remaining stuffs #3818

merged 1 commit into from Jan 21, 2020

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Dec 20, 2019 •
edited

Adds custom page for Noobaa System Custom Resource
Screenshot from 2020-01-07 09-46-33
Screenshot from 2020-01-07 09-46-27

Why in WIP?

  • Waiting for download and documentation links,

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/noobaa Related to noobaa-storage-plugin labels Dec 20, 2019
@bipuladh bipuladh force-pushed the nb-help-page branch 2 times, most recently from 1e5ac20 to 1ab9e31 Compare January 7, 2020 04:17
rawagner
rawagner suggested changes Jan 7, 2020
View reviewed changes
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/helper.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/infoPage.scss Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/infoPage.scss Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/infoPage.tsx
};

type InfoPageProps = {
obj: K8sResourceKind;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its better to use K8sResourceCommon see https://github.com/openshift/console/blob/master/frontend/public/module/k8s/index.ts#L115

or more specific type if applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K8sResourceCommon gives me an error since I am decomposing it to spec.

frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/infoPage.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
@bipuladh bipuladh requested a review from rawagner January 7, 2020 18:29
rawagner
rawagner reviewed Jan 8, 2020
View reviewed changes
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/infoPage.tsx Outdated
};
};

const getVersion = (obj: SpecObject): string => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually K8sResourceKind

Suggested change
const getVersion = (obj: SpecObject): string => {
const getVersion = (obj: K8sResourceKind): string => {

frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Outdated Show resolved Hide resolved
frontend/packages/noobaa-storage-plugin/src/components/noobaa-operator/resourceTable.tsx Show resolved Hide resolved
@bipuladh bipuladh force-pushed the nb-help-page branch 2 times, most recently from 5a7dd19 to cc2d723 Compare January 14, 2020 13:09
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2020
@bipuladh bipuladh changed the title [WIP] Noobaa Operators Page remaining stuffs Noobaa Operators Page remaining stuffs Jan 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor

/hold

e2e is broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 889e27e into openshift:master Jan 21, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@jhadvig jhadvig Awaiting requested review from jhadvig

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/noobaa Related to noobaa-storage-plugin lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bipuladh @rawagner @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot