Adding helm service endpoints to console #3826

akashshinde · 2019-12-23T09:20:25Z

NOTE: Need to get #3992 and #4007 merged before this PR.

This PR adds following helm service routes CC: @sbose78 @pedjak

/api/helm/releases - List all installed charts
/api/helm/template - Simulates helm template and renders manifest files.
/api/helm/release - Installs helm chart

To Test

Get Releases GET /api/helm/releases
Test : curl http://localhost:9000/api/helm/releases
Install Release POST /api/helm/release
Test: curl -X POST http://localhost:9000/api/helm/release
Body

{
	"name": "test-helm",
	"namespace": "akash-helm-server",
	"chart_url": "https://github.com/akashshinde/console/raw/helm_endpoints/pkg/helm/testdata/influxdb-3.0.2.tgz"
}

contrib/oc-environment.sh

pkg/helm_actions/rollback_release.go

benjaminapetersen · 2019-12-23T15:33:04Z

/hold

e2es are 100% failing

sbose78 · 2019-12-30T07:46:03Z

Cloning "https://github.com/akashshinde/console.git" ...
	Commit:	eff0686d14819b72634bdd4b58a2dedbb9aa4906 (go fmt)
	Author:	Akash Shinde <akashshinde159@gmail.com>
	Date:	Mon Dec 23 14:47:05 2019 +0530
Caching blobs under "/var/cache/blobs".

Pulling image openshift/origin-base ...
Getting image source signatures
Copying blob sha256:b2d2704dda6c98b6a775e8e5566af7a92f700b542905bd94310dc18b9bc2d0b0
Copying blob sha256:6e55351c18ffebc0918b4c21c1257d28d7e311bd37009fb722cb59761b7449ed
Copying blob ..
..
sha256:f17c3afdd8863b7b92d12e0a444b92dc76e56667d264ccc60882eed91b5627e6
Writing manifest to image destination
Storing signatures
STEP 1: FROM quay.io/coreos/tectonic-console-builder:v18 AS build
STEP 2: RUN mkdir -p /go/src/github.com/openshift/console/
4057c29e8afa2f3e11d6b4d0beec5d327f3a18e2e8dc68214c13e0955e862f53
STEP 3: ADD . /go/src/github.com/openshift/console/
54a988edc43ef2d9d9f95f7a2543cb1ac0c4c19d28c39c094d8ba9d7b415b373
STEP 4: WORKDIR /go/src/github.com/openshift/console/
41527da406326440983ea12947629fab8788db4038468bd4b194bd5d90a98fb4
STEP 5: RUN ./build.sh
# github.com/openshift/console/vendor/helm.sh/helm/v3/pkg/chart/loader
vendor/helm.sh/helm/v3/pkg/chart/loader/archive.go:145:7: undefined: strings.ReplaceAll
# github.com/openshift/console/vendor/helm.sh/helm/v3/pkg/kube
vendor/helm.sh/helm/v3/pkg/kube/client.go:520:21: undefined: strings.ReplaceAll
subprocess exited with status 2
subprocess exited with status 2
error: build error: error building at STEP "RUN ./build.sh": exit status 2

Tried building an image using https://github.com/openshift/console/blob/master/Dockerfile , the build failed with the above error.

Note: ReplaceAll(..) was added in 1.12. quay.io/coreos/tectonic-console-builder:v18 probably has a pre-1.12 golang version? https://github.com/openshift/console/blob/master/Dockerfile.builder#L5

sbose78

How about setting up the namespace context upfront?

pkg/helm_actions/install_chart.go

pkg/helm_actions/list_releases.go

pkg/helm_actions/upgrade_release.go

pkg/helm_agent/agent.go

pkg/helm/agent.go

pkg/helm/install_chart_test.go

pkg/helm/list_releases.go

pkg/helm/list_releases_test.go

pkg/server/server.go

pkg/helm/install_chart.go

pkg/helm/template.go

pkg/server/server.go

spadgett · 2020-01-13T14:11:32Z

/assign @benjaminapetersen

benjaminapetersen · 2020-01-15T17:24:13Z

pkg/server/server.go

@@ -417,3 +422,37 @@ func (s *Server) handleOpenShiftTokenDeletion(user *auth.User, w http.ResponseWr
 	io.Copy(w, resp.Body)
 	resp.Body.Close()
 }
+


Is it possible to move your handlers into your helm package? A handlers.go file would be fine, and just load them up via imports.

server.go doesn't need to know any details about helm, it can include the 3 lines setting up the handle("api/console/helm/....", authHandlerWithUser( helmcatalog.InstallHandler ). etc.

Would still like to see this change.

benjaminapetersen

Couple items organizationally.

pkg/server/server.go

benjaminapetersen · 2020-01-15T17:35:09Z

Suggested a couple small changes:

Package naming: 782c911#r367003903
Moving the handlers: 782c911#r367005771
Squash you commits to the following:
- dependencies + go.mod/go.sum
- feature code
- test code

Unless it makes sense to have more than 3 commits, this is probably the best pattern.

sbose78 · 2020-01-16T11:39:05Z

/retest

akashshinde · 2020-01-16T12:16:17Z

Suggested a couple small changes:

Package naming: 782c911#r367003903

Done renamed to helmcatalog. @sbose78 should we keep it helm only ?

Moving the handlers: 782c911#r367005771

As of now helm handler uses TLSConfig from Server obj, also handler uses sendResponse/apiError which are private in server package. This would need duplication of code.
@benjaminapetersen what do you think ?

Squash you commits to the following:

dependencies + go.mod/go.sum

feature code

test code

Added commits the way you suggested, I've been working on adding tests.

pedjak · 2020-01-16T14:52:17Z

@sbose78 @akashshinde I would name the package simply helm - IMHO, not seeing any additional benefits appending catalog to the name. We are crafting here a service that exposes helm functionalities, not only catalog functionalities. We could make it more fine-grained later if needed. #3928 introduces helm package as well.

sbose78 · 2020-01-16T20:28:09Z

@pedjak Agreed, go for it.

akashshinde · 2020-01-17T04:26:11Z

/retest

pkg/server/server.go

benjaminapetersen

See comments, thanks!

pkg/server/server.go

akashshinde · 2020-01-23T12:49:14Z

/test images

akashshinde · 2020-01-23T12:51:18Z

/test e2e-gcp-console

pedjak · 2020-01-23T13:48:14Z

/lgtm

akashshinde · 2020-01-23T14:36:31Z

/test e2e-gcp-console

akashshinde · 2020-01-23T18:58:57Z

/hold cancel

benjaminapetersen · 2020-01-23T19:48:20Z

Ok, give this one a squash down to 2 commits:

add deps for help service endpoints
add helm service endpoints

And we can take a final look, thanks!

sbose78 · 2020-01-23T21:04:00Z

/test analyze

benjaminapetersen · 2020-01-24T02:34:03Z

pkg/serverutils/utils.go

+	plog = capnslog.NewPackageLogger("github.com/openshift/console", "serverutils")
+)
+
+// Copied from Server package to maintain error response consistency


A follow, we can eliminate this comment since its no longer copied. This is the only occurance.

benjaminapetersen · 2020-01-24T02:38:13Z

/retest

NoSuchElementError: Index out of bound. Trying to access element at index: 0, but there are only 0 elements that match locator By(css selector, [placeholder="value"])
    at selenium_webdriver_1.promise.all.then (/go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:274:27)
    at ManagedPromise.invokeCallback_ (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1376:14)
    at TaskQueue.execute_ (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3084:14)
    at TaskQueue.executeNext_ (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:3067:27)
    at asyncRun (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:2927:27)
    at /go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:668:7
    at process._tickCallback (internal/process/next_tick.js:68:7)Error
    at ElementArrayFinder.applyAction_ (/go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:459:27)
    at ElementArrayFinder.(anonymous function).args [as getAttribute] (/go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:91:29)
    at ElementFinder.(anonymous function).args [as getAttribute] (/go/src/github.com/openshift/console/frontend/node_modules/protractor/built/element.js:831:22)
    at /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:70:75
    at /go/src/github.com/openshift/console/frontend/integration-tests/protractor.conf.ts:267:18
    at step (/go/src/github.com/openshift/console/frontend/integration-tests/protractor.conf.ts:33:23)
    at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/protractor.conf.ts:14:53)
    at /go/src/github.com/openshift/console/frontend/integration-tests/protractor.conf.ts:8:71
    at new ManagedPromise (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/promise.js:1077:7)
    at __awaiter (/go/src/github.com/openshift/console/frontend/integration-tests/protractor.conf.ts:4:12)

Your code doesn't touch the frontend, flake.

benjaminapetersen · 2020-01-24T02:38:19Z

/lgtm

openshift-ci-robot · 2020-01-24T02:39:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, benjaminapetersen, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

akashshinde · 2020-01-24T06:38:13Z

/test e2e-gcp-console

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/backend Related to backend labels Dec 23, 2019

openshift-ci-robot requested review from rhamilto and spadgett December 23, 2019 09:21

akashshinde commented Dec 23, 2019

View reviewed changes

contrib/oc-environment.sh Outdated Show resolved Hide resolved

sbose78 reviewed Dec 23, 2019

View reviewed changes

pkg/helm_actions/rollback_release.go Outdated Show resolved Hide resolved

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2019

sbose78 reviewed Dec 30, 2019

View reviewed changes

pkg/helm_actions/install_chart.go Outdated Show resolved Hide resolved

pkg/helm_actions/list_releases.go Outdated Show resolved Hide resolved

pkg/helm_actions/upgrade_release.go Outdated Show resolved Hide resolved

pedjak force-pushed the helm_endpoints branch from eff0686 to d8d3aa5 Compare December 30, 2019 09:11

sbose78 reviewed Dec 30, 2019

View reviewed changes

pkg/helm_agent/agent.go Outdated Show resolved Hide resolved

rohitkrai03 mentioned this pull request Jan 6, 2020

Add support for listing and installation of Helm Charts from Dev Catalog #3850

Merged

sbose78 mentioned this pull request Jan 9, 2020

Design proposal for implementing helm support in OpenShift Console openshift/enhancements#175

Merged

pedjak suggested changes Jan 13, 2020

View reviewed changes

openshift-ci-robot assigned benjaminapetersen Jan 13, 2020

rohitkrai03 mentioned this pull request Jan 14, 2020

Add Helm Release List Page #3960

Merged

benjaminapetersen reviewed Jan 15, 2020

View reviewed changes

benjaminapetersen suggested changes Jan 15, 2020

View reviewed changes

benjaminapetersen reviewed Jan 15, 2020

View reviewed changes

pkg/server/server.go Outdated Show resolved Hide resolved

sbose78 mentioned this pull request Jan 16, 2020

Added helm chart repo proxy to the console backend #3928

Merged

akashshinde force-pushed the helm_endpoints branch from 899ec1a to 7e6a472 Compare January 16, 2020 11:40

benjaminapetersen reviewed Jan 22, 2020

View reviewed changes

pkg/server/server.go Outdated Show resolved Hide resolved

benjaminapetersen suggested changes Jan 22, 2020

View reviewed changes

pkg/server/server.go Outdated Show resolved Hide resolved

akashshinde force-pushed the helm_endpoints branch from d0dbb6b to e83e8fd Compare January 22, 2020 18:42

akashshinde requested a review from benjaminapetersen January 22, 2020 19:52

akashshinde force-pushed the helm_endpoints branch from a8a1287 to 8eae8a9 Compare January 23, 2020 10:43

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020

akashshinde added 2 commits January 24, 2020 01:26

Add deps for help service endpoints

e702903

Add helm service endpoints

cdf6b18

akashshinde force-pushed the helm_endpoints branch from 6a9fc1b to cdf6b18 Compare January 23, 2020 19:57

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

benjaminapetersen reviewed Jan 24, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

benjaminapetersen approved these changes Jan 24, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020

openshift-merge-robot merged commit b62c1df into openshift:master Jan 24, 2020

sbose78 mentioned this pull request Jan 24, 2020

Helm release resources page #4013

Merged

pedjak mentioned this pull request Jan 24, 2020

Added helm endpoint to get infos about the given release #4059

Merged

spadgett added this to the v4.4 milestone Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding helm service endpoints to console #3826

Adding helm service endpoints to console #3826

akashshinde commented Dec 23, 2019 •

edited

benjaminapetersen commented Dec 23, 2019

sbose78 commented Dec 30, 2019 •

edited

sbose78 left a comment

spadgett commented Jan 13, 2020

benjaminapetersen Jan 15, 2020

benjaminapetersen Jan 21, 2020

benjaminapetersen left a comment

benjaminapetersen commented Jan 15, 2020

sbose78 commented Jan 16, 2020

akashshinde commented Jan 16, 2020 •

edited

pedjak commented Jan 16, 2020

sbose78 commented Jan 16, 2020

akashshinde commented Jan 17, 2020

benjaminapetersen left a comment

akashshinde commented Jan 23, 2020

akashshinde commented Jan 23, 2020

pedjak commented Jan 23, 2020

akashshinde commented Jan 23, 2020

akashshinde commented Jan 23, 2020

benjaminapetersen commented Jan 23, 2020

sbose78 commented Jan 23, 2020

benjaminapetersen Jan 24, 2020

benjaminapetersen commented Jan 24, 2020

benjaminapetersen commented Jan 24, 2020

openshift-ci-robot commented Jan 24, 2020

akashshinde commented Jan 24, 2020

Adding helm service endpoints to console #3826

Adding helm service endpoints to console #3826

Conversation

akashshinde commented Dec 23, 2019 • edited

To Test

benjaminapetersen commented Dec 23, 2019

sbose78 commented Dec 30, 2019 • edited

sbose78 left a comment

Choose a reason for hiding this comment

spadgett commented Jan 13, 2020

benjaminapetersen Jan 15, 2020

Choose a reason for hiding this comment

benjaminapetersen Jan 21, 2020

Choose a reason for hiding this comment

benjaminapetersen left a comment

Choose a reason for hiding this comment

benjaminapetersen commented Jan 15, 2020

sbose78 commented Jan 16, 2020

akashshinde commented Jan 16, 2020 • edited

pedjak commented Jan 16, 2020

sbose78 commented Jan 16, 2020

akashshinde commented Jan 17, 2020

benjaminapetersen left a comment

Choose a reason for hiding this comment

akashshinde commented Jan 23, 2020

akashshinde commented Jan 23, 2020

pedjak commented Jan 23, 2020

akashshinde commented Jan 23, 2020

akashshinde commented Jan 23, 2020

benjaminapetersen commented Jan 23, 2020

sbose78 commented Jan 23, 2020

benjaminapetersen Jan 24, 2020

Choose a reason for hiding this comment

benjaminapetersen commented Jan 24, 2020

benjaminapetersen commented Jan 24, 2020

openshift-ci-robot commented Jan 24, 2020

akashshinde commented Jan 24, 2020

akashshinde commented Dec 23, 2019 •

edited

sbose78 commented Dec 30, 2019 •

edited

akashshinde commented Jan 16, 2020 •

edited