Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds spec for RevisionRow component #3833

Merged
merged 1 commit into from Jan 3, 2020
Merged

adds spec for RevisionRow component #3833

merged 1 commit into from Jan 3, 2020

Conversation

invincibleJai
Copy link
Member

adds spec for RevisionRow component

Tracks: https://issues.redhat.com/browse/ODC-2640

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2019
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/knative Related to knative-plugin labels Dec 27, 2019
vikram-raj
vikram-raj reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2019
vikram-raj
vikram-raj reviewed Dec 27, 2019
View reviewed changes
frontend/packages/knative-plugin/src/components/revisions/__tests__/RevisionRow.spec.tsx
import { TableData } from '@console/internal/components/factory';
import { ResourceLink } from '@console/internal/components/utils';
import { K8sResourceConditionStatus } from '@console/internal/module/k8s';
import { revisionObj } from '@console/dev-console/src/components/topology/__tests__/topology-knative-test-data';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wrong dependency. knative-plugin should have no dependency on dev-console packages. Not for this PR but create a task to fix this dependency issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have this dependency right now. Knative Plugin depends on dev-console to render stuff in topology and a lot of other such instances. We probably need to come up with a runtime extensibility framework to fully eliminate the dependency.

@invincibleJai
Copy link
Member Author

/assign @rohitkrai03 @andrewballantyne

rohitkrai03
rohitkrai03 approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

frontend/packages/knative-plugin/src/components/revisions/__tests__/RevisionRow.spec.tsx
import { TableData } from '@console/internal/components/factory';
import { ResourceLink } from '@console/internal/components/utils';
import { K8sResourceConditionStatus } from '@console/internal/module/k8s';
import { revisionObj } from '@console/dev-console/src/components/topology/__tests__/topology-knative-test-data';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have this dependency right now. Knative Plugin depends on dev-console to render stuff in topology and a lot of other such instances. We probably need to come up with a runtime extensibility framework to fully eliminate the dependency.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@andrewballantyne
Copy link
Contributor

/kind cleanup

@openshift-ci-robot openshift-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 2, 2020
@andrewballantyne
Copy link
Contributor

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 631e1eb into openshift:master Jan 3, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@vikram-raj vikram-raj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@invincibleJai @openshift-ci-robot @openshift-bot @andrewballantyne @vikram-raj @rohitkrai03 @spadgett @openshift-merge-robot