Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1802594: test for group-by dropdown #3871

Merged
merged 1 commit into from Feb 13, 2020
Merged

Bug 1802594: test for group-by dropdown #3871

merged 1 commit into from Feb 13, 2020

Conversation

debsmita1
Copy link
Contributor

This PR checks for the group-by dropdown in the dev catalog page
Jira : https://issues.redhat.com/browse/ODC-2668

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2020
@andrewballantyne
Copy link
Contributor

/kind cleanup

@openshift-ci-robot openshift-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 7, 2020
rohitkrai03
rohitkrai03 approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@christianvogt
Copy link
Contributor

/approve

@debsmita1
Copy link
Contributor Author

/assign @vojtechszocs

vojtechszocs
vojtechszocs reviewed Feb 12, 2020
View reviewed changes
frontend/__tests__/components/catalog.spec.tsx Outdated
@@ -110,9 +111,15 @@ describe(CatalogTileViewPage.displayName, () => {
});
});

it('should render the group-by dropdown ', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should render the group-by dropdown ', () => {
it('should render the group-by dropdown', () => {

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 12, 2020
@vojtechszocs
Copy link
Contributor

/lgtm

benjaminapetersen
benjaminapetersen approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, christianvogt, debsmita1, rohitkrai03, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debsmita1 debsmita1 changed the title test for group-by dropdown Bug 1802594: test for group-by dropdown Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1802594, which is valid. The bug has been moved to the POST state.

In response to this:

Bug 1802594: test for group-by dropdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 13, 2020
@debsmita1
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7b1a1eb into openshift:master Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: All pull requests linked via external trackers have merged. Bugzilla bug 1802594 has been moved to the MODIFIED state.

In response to this:

Bug 1802594: test for group-by dropdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@vojtechszocs vojtechszocs vojtechszocs approved these changes

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@benjaminapetersen benjaminapetersen

@vojtechszocs vojtechszocs

@rohitkrai03 rohitkrai03

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@debsmita1 @andrewballantyne @christianvogt @vojtechszocs @openshift-ci-robot @benjaminapetersen @rohitkrai03 @spadgett @openshift-merge-robot