Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shyRozen to owners file #3903

Merged
merged 1 commit into from Jan 22, 2020
Merged

Add shyRozen to owners file #3903

merged 1 commit into from Jan 22, 2020

Conversation

shyRozen
Copy link
Contributor

@shyRozen shyRozen commented Jan 9, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Jan 9, 2020
cloudbehl
cloudbehl reviewed Jan 9, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/OWNERS
@@ -5,11 +5,13 @@ reviewers:
- cloudbehl
- gnehapk
- rawagner
- shyRozen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create OWNERS file inside the integration-tests folder and give access to reviewers and Approvers over there.

@afreen23
Copy link
Contributor

afreen23 commented Jan 10, 2020 •
edited

Welcome @shyRozen :)

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
@cloudbehl
Copy link
Contributor

Do you also want to do same for noobaa plugin?

@shyRozen
Copy link
Contributor Author

Do you also want to do same for noobaa plugin?
@cloudbehl I can do it also.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/noobaa Related to noobaa-storage-plugin and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2020
@cloudbehl
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2020
bipuladh
bipuladh reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl, ebenahar, shyRozen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit df8b5da into openshift:master Jan 22, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl left review comments

@bipuladh bipuladh bipuladh left review comments

@ebenahar ebenahar ebenahar approved these changes

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@cloudbehl cloudbehl

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/noobaa Related to noobaa-storage-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@shyRozen @afreen23 @cloudbehl @openshift-ci-robot @ebenahar @bipuladh @spadgett @openshift-merge-robot