kubevirt: enhance memory validation and template selection #3909

atiratree · 2020-01-09T14:32:19Z

unify and enhance template selections for validation and create requests
use GiB instead of GB for memory to allign with validations
show validation intervals

@yaacov @irosenzw

depends on

shared: make separator optional in joinGrammaticallyListOfItems #3910

atiratree · 2020-01-09T14:49:22Z

keeps the validations messages and shows the options when all validation fail

atiratree · 2020-01-10T12:53:24Z

@rhrazdil fyi wizard will be using GiB after this change

yaacov · 2020-01-12T08:36:49Z

...components/create-vm-wizard/redux/stateUpdate/vmSettings/prefill-vm-template-state-update.ts

@@ -85,6 +85,8 @@ export const prefillVmTemplateUpdater = ({ id, dispatch, getState }: UpdateOptio
    [VMSettingsField.WORKLOAD_PROFILE]: { value: null },
    [VMSettingsField.PROVISION_SOURCE_TYPE]: { value: isProviderImport ? undefined : null },
    [VMSettingsField.HOSTNAME]: { value: null },
+    [VMSettingsField.CPU]: { value: null },
+    [VMSettingsField.MEMORY]: { value: null },


yaacov · 2020-01-12T08:47:31Z

...evirt-plugin/src/components/create-vm-wizard/redux/validations/vm-settings-tab-validation.ts

  if (validations.length === 0) {
-    return null;
+    validations.push(new TemplateValidations()); // add empty validation for positive integer if it is missing one


why not exit here, empty validation will end up in line 121 anyway ... ? what am I missing here ?

This just adds default validation for positive integer (not empty one), so there is no chance to insert negative values or 0

👍 don't we have some other mechanism to enforce that ?

we do, but just on the UI side in our component. IMO it will not hurt to have it also here

irosenzw · 2020-01-14T13:53:41Z

...virt-plugin/src/components/create-vm-wizard/redux/validations/utils/templates-validations.ts

+
+  if (templates.size > 0 && os && workload) {
+    // templates are sorted by relevance if only flavor is missing
+    return getValidationsFromTemplates([templates.first()]);


@suomiy Why returning the validations from just one template? why not all of them ?
I think lines 38 and 41 should be switched. Am I wrong ?

I refactored the code to make the intent more clear and added a comment. Can you please check the code if it makes sense to you?

irosenzw · 2020-01-14T14:37:34Z

frontend/packages/kubevirt-plugin/src/utils/validations/template/template-validations.ts

+    const relevantValidations = this.getRelevantValidations(jsonPath);
+
+    // combine validations for single template and make them strict (all integer validations must pass)
+    const { min, max, isMinInclusive, isMaxInclusive } = relevantValidations.reduce(


We should consider the option that a validation is optional - a.k.a has the key justWarning.
optional validation shouldn't be combined and enforced.

right! added the support for justWarning

Fixes: CNV-2914 - Enforce the validations from common and user templates so the user can choose only from the allowed values in the Disk-modal at the storage tab. - Add the validations to the store. - Implement enum validation methods. Depends on: openshift#3909 Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

Fixes: CNV-2914 - Enforce the validations from common and user templates so the user can choose only from the allowed values in the Disk-modal at the storage tab. - Add the validations to the store. - Implement enum validation methods. Depends on: openshift#3909 Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

atiratree · 2020-01-16T23:36:47Z

template with justWarning validation found:

atiratree · 2020-01-20T16:13:48Z

rebased

irosenzw

/lgtm

irosenzw · 2020-01-21T09:26:57Z

/lgtm

atiratree · 2020-01-21T09:27:59Z

/retest

openshift-bot · 2020-01-21T09:31:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

atiratree · 2020-01-21T09:47:55Z

/retest

openshift-bot · 2020-01-21T09:57:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

- unify and enhance template selections for validation and create requests - use GiB instead of GB for memory to allign with validations - show validation intervals

atiratree · 2020-01-21T10:05:06Z

fixed interval description: now uses at least and at most

irosenzw · 2020-01-21T10:08:47Z

/lgtm

openshift-ci-robot · 2020-01-21T10:09:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-21T12:46:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Fixes: CNV-2914 Enforce the validations from common and user templates so the user can choose only from the allowed values in the Disk-modal at the storage tab. Depends on: openshift#3909 Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

atiratree · 2020-01-21T19:41:25Z

/retest

spadgett · 2020-01-21T23:17:53Z

/hold
the merge queue is blocked

spadgett · 2020-01-22T01:31:40Z

/hold cancel
/retest

openshift-bot · 2020-01-22T02:42:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Fixes: CNV-2914 Enforce the validations from common and user templates so the user can choose only from the allowed values in the Disk-modal at the storage tab. Depends on: openshift#3909 Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2020

openshift-ci-robot requested review from spadgett and yaacov January 9, 2020 14:32

openshift-ci-robot added component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Jan 9, 2020

atiratree mentioned this pull request Jan 9, 2020

shared: make separator optional in joinGrammaticallyListOfItems #3910

Merged

yaacov reviewed Jan 12, 2020

View reviewed changes

irosenzw reviewed Jan 14, 2020

View reviewed changes

irosenzw mentioned this pull request Jan 15, 2020

Show only the allowed storage interfaces on Disk-modal #3973

Closed

atiratree force-pushed the kubevirt.memoryValidation branch from f9c09da to a3df828 Compare January 16, 2020 20:38

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2020

atiratree force-pushed the kubevirt.memoryValidation branch from a3df828 to ccd10ca Compare January 16, 2020 20:45

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 16, 2020

atiratree force-pushed the kubevirt.memoryValidation branch from ccd10ca to aa575ff Compare January 16, 2020 22:41

atiratree force-pushed the kubevirt.memoryValidation branch 3 times, most recently from b2473ca to a87aaa6 Compare January 20, 2020 16:13

irosenzw reviewed Jan 21, 2020

View reviewed changes

kubevirt: enhance memory validation and template selection

1178a24

- unify and enhance template selections for validation and create requests - use GiB instead of GB for memory to allign with validations - show validation intervals

atiratree force-pushed the kubevirt.memoryValidation branch from a87aaa6 to 1178a24 Compare January 21, 2020 10:03

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

irosenzw mentioned this pull request Jan 21, 2020

Show only the allowed storage interfaces on Disk-modal #4028

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

openshift-merge-robot merged commit 3a0cce3 into openshift:master Jan 22, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubevirt: enhance memory validation and template selection #3909

kubevirt: enhance memory validation and template selection #3909

atiratree commented Jan 9, 2020 •

edited

atiratree commented Jan 9, 2020

atiratree commented Jan 10, 2020

yaacov Jan 12, 2020

yaacov Jan 12, 2020

atiratree Jan 13, 2020

yaacov Jan 13, 2020

atiratree Jan 13, 2020

irosenzw Jan 14, 2020 •

edited

atiratree Jan 16, 2020

irosenzw Jan 14, 2020

atiratree Jan 16, 2020

atiratree commented Jan 16, 2020

atiratree commented Jan 20, 2020

irosenzw left a comment •

edited

irosenzw commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

irosenzw commented Jan 21, 2020

openshift-ci-robot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

spadgett commented Jan 21, 2020

spadgett commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

kubevirt: enhance memory validation and template selection #3909

kubevirt: enhance memory validation and template selection #3909

Conversation

atiratree commented Jan 9, 2020 • edited

atiratree commented Jan 9, 2020

atiratree commented Jan 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irosenzw Jan 14, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Jan 16, 2020

atiratree commented Jan 20, 2020

irosenzw left a comment • edited

Choose a reason for hiding this comment

irosenzw commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

irosenzw commented Jan 21, 2020

openshift-ci-robot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

spadgett commented Jan 21, 2020

spadgett commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

atiratree commented Jan 9, 2020 •

edited

irosenzw Jan 14, 2020 •

edited

irosenzw left a comment •

edited