feat(topology-resourcemenu): add resource menu actions #3918

karthikjeeyar · 2020-01-10T16:44:56Z

Added custom actions to redirect (with queryparams) to import flow pages from topology
Added submenus from #3922, RBAC checks for actions, aligned it with latest UX design and added unit tests

For Users with limited permission menu items will be disabled:

Fixes: https://issues.redhat.com/browse/ODC-2602

andrewballantyne · 2020-01-10T17:34:14Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+      pageUrl = `add/ns/${ns}`;
+  }
+  const seperator = pageUrl.includes('?') ? '&' : '?';
+  return `${pageUrl}${seperator}component=${obj.metadata.name}&isKnativeDisabled=${obj.kind ===


It's important to note URLs are tricky beasts... always use encodeURIComponent when crafting a url with dynamic values (MDN ref)

Suggested change

return `${pageUrl}${seperator}component=${obj.metadata.name}&isKnativeDisabled=${obj.kind ===

return `${pageUrl}${seperator}component=${encodeURIComponent(obj.metadata.name)}&isKnativeDisabled=${obj.kind ===

christianvogt · 2020-01-11T02:06:43Z

@karthikjeeyar the final designs state that there should be an Add to Application menu item in the context menu of an application and an Add to Project menu item in the context menu of the surface. There are no Add menu items on resources.

karthikjeeyar · 2020-01-13T09:56:29Z

@karthikjeeyar the final designs state that there should be an Add to Application menu item in the context menu of an application and an Add to Project menu item in the context menu of the surface. There are no Add menu items on resources.

@christianvogt I will use the Sub menu PR #3922 that you have created and align the UI with final design

andrewballantyne · 2020-01-13T16:37:11Z

/kind feature

andrewballantyne

Looking good, I have a few general remarks about the coding style but the logic looks pretty good. We'll need to make sure we combine everything after we individually get our stuff in.

andrewballantyne · 2020-01-14T16:27:14Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+  if (!hasApplication || !appGroup) {
+    return `${pageUrl}${seperator}&isKnativeDisabled=true`;
+  }
+  return `${pageUrl}${seperator}application=${encodeURIComponent(appGroup)}&isKnativeDisabled=true`;


We also need the param contextSource which is a string of ${versionKindGroup}/${app-name} from your obj. This was discovered after you started your work, but given the status of the PR I think we can wrap it into this work.

After reviewing more and understanding your goal. I think this will need to be modified by the in-context stuff @nemesis09 is working on.

Right, @nemesis09 will be passing the contextSource as a queryparams

andrewballantyne · 2020-01-14T16:27:49Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+    case ImportOptions.CATALOG:
+      pageUrl = '/catalog';
+      break;


This is going to be annoying. The ~new screen isn't keeping any of the params. I haven't completely dug into it yet.

andrewballantyne · 2020-01-14T16:28:28Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+  const appGroup = _.get(obj, ['metadata', 'labels', PART_OF], '');
+
+  if (!hasApplication || !appGroup) {
+    return `${pageUrl}${seperator}&isKnativeDisabled=true`;


What's the purpose of isKnativeDisabled?

The assumption is to handle add resource only for the normal resource(D, DC, etc). Knative revisions can only be the source (never acts as a target), so if we need to disable the knative option add form, we can use this param

andrewballantyne · 2020-01-14T16:30:04Z

frontend/packages/dev-console/src/components/import/import-types.ts

+  CATALOG = 'CATALOG',
+  DOCKERFILE = 'DOCKERFILE',
+  DATABASE = 'DATABASE',
+  EVENTSOURCE = 'EVENTSOURCE',


Is this a valid option atm? Shouldn't we leave this as part of the Event Source creation path?

Removed this option atm

andrewballantyne · 2020-01-14T16:30:26Z

frontend/packages/dev-console/src/components/topology/actions/graphActions.ts

+import { TYPE_WORKLOAD } from '../const';
+import { addResourceMenu } from '../../../actions/add-resources';
+
+const addResourcesMenu = (workload) => {


I don't think workload is a K8sResourceKind is it? What is the type?

Type is TopologyDataObject, added it

andrewballantyne · 2020-01-15T01:50:41Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+export const EventSource = (obj: K8sResourceKind, hasApplication?: boolean): KebabOption => {
+  const resourceModel = modelFor(referenceFor(obj));
+  return {
+    path: getMenuPath(hasApplication),
+    label: 'Event Source',
+    href: getAddPageUrl(obj, ImportOptions.EVENTSOURCE, hasApplication),
+    icon: <UnknownIcon />,
+    accessReview: asAccessReview(resourceModel, obj, 'create'),
+  };
+};


I don't think we need this today. Since EventSource creation is not likely making it in 4.4

Yes, I will remove the event source creation option atm

andrewballantyne · 2020-01-15T01:52:30Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+import { ImportOptions } from '../components/import/import-types';
+import { getMenuPath, getAddPageUrl } from '../utils/add-resources-menu-utils';
+
+export const FromGit = (obj?: K8sResourceKind, hasApplication?: boolean): KebabOption => {


Suggested change

export const FromGit = (obj?: K8sResourceKind, hasApplication?: boolean): KebabOption => {

export const fromGit = (obj?: K8sResourceKind, hasApplication?: boolean): KebabOption => {

Not a type, class or a component... camelCase not PascalCase please. Repeat for each of the other functions.

andrewballantyne · 2020-01-15T02:16:52Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+  };
+};
+
+export const ContainerImage = (obj: K8sResourceKind, hasApplication?: boolean): KebabOption => {


You're repeating yourself quite a bit here... I think something like currying (lots of resources on the web for this concept if you want to know more) could be of use here where you store some static variables at the start and return a function that can make the actual KebabOption at a later time (when invoked).

// From my other comment type KebabAction = (obj?: K8sResourceKind, hasApplication?: boolean) => KebabOption; // Currying-based type type KebabFactory = ( label: string, icon: React.ReactNode, importType: ImportOptions, ) => KebabAction; // One setup that consumes both stages export const createKebabOption: KebabFactory = (label, icon, importType) => ( obj, hasApplication, ) => { const resourceModel = modelFor(referenceFor(obj)); return { path: getMenuPath(hasApplication), label, href: getAddPageUrl(obj, importType, hasApplication), icon, accessReview: asAccessReview(resourceModel, obj, 'create'), }; }; // Setup each option with statics values that returns a function to be // consumed later and provide the rest of the options export const fromGit = createKebabOption('From Git', <GitAltIcon />, ImportOptions.GIT); export const containerImage = createKebabOption( 'Container Image', <OsImageIcon />, ImportOptions.CONTAINER, );

I didn't spend any time on the variable / function / type names, so by all means adjust as you see fit. But I think this will help you repeat less in this file and give easy access to adding new flows.

refactored it, definitely looks better now.

andrewballantyne · 2020-01-15T02:20:07Z

frontend/packages/dev-console/src/components/topology/nodeContextMenu.tsx

 const nodeContextMenu = (element: Node) =>
  createMenuItems(kebabOptionsToMenu(nodeActions(element.getData())));

-export { workloadContextMenu, groupContextMenu, nodeContextMenu };


Well this is an odd way to export out of this file

@christianvogt 👀 Looking at you 😃

Thanks for the improvement @karthikjeeyar, looks good.

Don't look at me... Jeff did it :P

andrewballantyne · 2020-01-15T02:32:47Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+    default:
+      pageUrl = `add/ns/${ns}`;
+  }
+  const seperator = pageUrl.includes('?') ? '&' : '?';


You could use URLSearchParams to manage all your attributes. Create it at the start and just .append to it in some case statements and let it do it's magic. Then just searchParams.toString() at the end to get the output:
searchParams.toString(); // "q=URLUtils.searchParams&topic=More+webdev"

andrewballantyne · 2020-01-15T02:45:27Z

@karthikjeeyar I think you missed the first case in the designs

Right-click on a node(image area or label) to invoke the in-context action menu on topology view. The ‘Add Resources’ option could be accessed from this menu

cc @openshift/team-devconsole-ux

karthikjeeyar · 2020-01-16T11:38:36Z

@andrewballantyne I have checked with UX team, There is no right click action in the node (Doc is not updated properly), its only on group and outside group, Node action will be part of connector work that @nemesis09 is doing.

Check this comment : #3918 (comment)

andrewballantyne · 2020-01-16T13:14:24Z

Check this comment : #3918 (comment)

This whole thing was a lot more confusing than it needed to be and not at all straight forward on the docs. Apparently yes, Christian is correct and the UX is being adjusted in the docs to match that.

Carry on! 😄

andrewballantyne

Looking better, just a couple more remarks...

andrewballantyne · 2020-01-16T15:27:30Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+import { ImportOptions } from '../components/import/import-types';
+import { KebabAction, createKebabOption } from '../utils/add-resources-menu-utils';
+
+export const fromGit = createKebabOption('From Git', <GitAltIcon />, ImportOptions.GIT);


Doh, this is likely my bad. Can we actually call this method "createKebabAction" since what it returns is a function (KebabAction) that will create the option at a later time?

Suggested change

export const fromGit = createKebabOption('From Git', <GitAltIcon />, ImportOptions.GIT);

export const fromGit = createKebabAction('From Git', <GitAltIcon />, ImportOptions.GIT);

andrewballantyne · 2020-01-16T15:28:30Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+  <CubeIcon />,
+  ImportOptions.DOCKERFILE,
+);
+export const database = createKebabOption('Database', <DatabaseIcon />, ImportOptions.DATABASE);


Suggested change

export const database = createKebabOption('Database', <DatabaseIcon />, ImportOptions.DATABASE);

export const fromDatabaseCatalog = createKebabOption('Database', <DatabaseIcon />, ImportOptions.DATABASE);

? Since it's really just the catalog with a filter.

andrewballantyne · 2020-01-16T15:43:13Z

frontend/packages/dev-console/src/components/topology/nodeContextMenu.tsx

 const nodeContextMenu = (element: Node) =>
  createMenuItems(kebabOptionsToMenu(nodeActions(element.getData())));

-export { workloadContextMenu, groupContextMenu, nodeContextMenu };


Thanks for the improvement @karthikjeeyar, looks good.

andrewballantyne · 2020-01-16T15:44:02Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.ts

+    expect(addResourceMenu).toEqual([
+      fromGit,
+      containerImage,
+      fromCatalog,
+      fromDockerfile,
+      database,
+    ]);


Not sure this is a helpful test... it's just coupled to the variable. Doesn't test any change in logic.

Agreed, i have removed it.

andrewballantyne · 2020-01-16T15:45:00Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.ts

+    let menuTitle = '';
+    menuTitle = getMenuPath(true);
+    expect(menuTitle).toEqual('Add to Application');
+
+    menuTitle = getMenuPath(false);
+    expect(menuTitle).toEqual('Add to Project');


It's a pretty simple and straight forward check... you could just do it in two lines:

expect(getMenuPath(true)).toEqual('Add to Application'); expect(getMenuPath(false)).toEqual('Add to Project');

andrewballantyne · 2020-01-16T15:47:35Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.ts

@@ -0,0 +1,131 @@
+import { URL } from 'url';
+import { getMenuPath, getAddPageUrl } from '../add-resources-menu-utils';


I think you are missing a test for createKebabAction (ie createKebabOption), and making sure it produces a KebabOption after being invoked.

add test case for createKebabAction

andrewballantyne · 2020-01-16T15:56:35Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.ts

+    // Negative checks for queryparams params.
+    expect(url.searchParams.has('preselected-ns')).toBe(false);
+    expect(url.searchParams.has('catagory')).toBe(false);


Hmmm, I wonder if we couldn't just use something like Array.from(url.searchParams.entries()).length to validate how many we expected it to have. That way we don't have specific tests against other path params.

Same deal for the other tests as well.

andrewballantyne · 2020-01-16T16:02:02Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.ts

+    expect(url.searchParams.has('preselected-ns')).toBe(false);
+    expect(url.searchParams.has('catagory')).toBe(false);


I think we can drop these two asserts... Really all we are looking for on this test is that you don't get an application param.

andrewballantyne · 2020-01-16T16:03:23Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+      params.append('category', 'databases');
+      break;
+    default:
+      pageUrl = `add/ns/${ns}`;


Hmm, I probably should handle this in my PR... Since if they land there now, they'll likely lose all their params on the first navigate.

I don't think we have a use case where we want to land at the +Add page in context.

andrewballantyne · 2020-01-16T18:49:23Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.tsx

+  it('it should return a valid kebabAction on invoking createKebabAction', () => {
+    const { resource } = getTopologyData(MockResources, ['deployments']);
+    const kebabAction = createKebabAction('From Git', <GitAltIcon />, ImportOptions.GIT);
+    expect(kebabAction(resource, true)).toHaveProperties([
+      'label',
+      'icon',
+      'path',
+      'href',
+      'accessReview',
+    ]);
+  });


You use toHaveProperties once here, and I don't think you're doing anything special here that warranted hiding the logic under the utility you created. Recommend a more direct approach, it's just an object and you know what structure you're getting (a KebabOption) so test for that:

it('should return a valid KebabOption on invoking a new KebabAction', () => { const { resource } = getTopologyData(MockResources, ['deployments']); const icon = <GitAltIcon />; const hasApplication = true; const label = 'From Git'; const kebabAction: KebabAction = createKebabAction(label, icon, ImportOptions.GIT); const kebabOption: KebabOption = kebabAction(resource, hasApplication); expect(kebabOption.label).toEqual(label); expect(kebabOption.icon).toEqual(icon); expect(kebabOption.path).toEqual('Add to Application'); expect(kebabOption.href).toEqual(getAddPageUrl(resource, ImportOptions.GIT, hasApplication)); expect(kebabOption.accessReview).toEqual(asAccessReview(DeploymentModel, resource, 'create')); });

Should be noted I changed your test name as well, you had a couple issues with it.

Also delete the toHaveProperties extension at the top of the file.

I used functions calls for href and accessReview as you're not really testing an explicit output, you're just using what they provide.

andrewballantyne · 2020-01-16T18:50:06Z

frontend/packages/dev-console/src/utils/__tests__/add-resources-menu-utils.spec.tsx

+  it('should return the page url with proper queryparams for git import flow', () => {
+    const { resource } = getTopologyData(MockResources, ['deployments']);
+    const url = new URL(getAddPageUrl(resource, ImportOptions.GIT, true), 'https://mock.test.com');
+    // Check that url contains all expected params


Since you have to make a change already, can you remove all these comments as they don't attribute themselves to the test structure anymore.

andrewballantyne · 2020-01-16T18:59:03Z

You also have an issue with lint, please check that at the same time.

karthikjeeyar · 2020-01-17T05:13:46Z

/retest

karthikjeeyar · 2020-01-17T05:19:38Z

/test frontend

invincibleJai · 2020-01-17T05:51:48Z

/test frontend

andrewballantyne · 2020-01-17T15:22:39Z

/lgtm
/retest

No approval powers here 😞

/assign @christianvogt

serenamarie125 · 2020-01-19T22:26:58Z

@karthikjeeyar question regarding RBAC ...

In the case where the user only has Read access to this project, those Add to Project/Application menu items shouldn't be added at all, similarly to how the +Add nav item is not added/shown.

Can you verify that is the case? Thanks!

karthikjeeyar · 2020-01-20T06:14:07Z

@karthikjeeyar question regarding RBAC ...

In the case where the user only has Read access to this project, those Add to Project/Application menu items shouldn't be added at all, similarly to how the +Add nav item is not added/shown.

Can you verify that is the case? Thanks!

@serenamarie125 Currently, For user with limited permission, I am showing all the menu items options disabled in the add menu, if we want to remove it , then should we need to keep From Catalog and Database in menu items?

User with view permission will see these options in Add page now, even though they dont have add permission.

karthikjeeyar · 2020-01-20T06:43:47Z

/retest

christianvogt · 2020-01-20T16:18:56Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+      params.append('category', 'databases');
+      break;
+    default:
+      pageUrl = `add/ns/${ns}`;


I don't think we have a use case where we want to land at the +Add page in context.

christianvogt · 2020-01-20T16:19:27Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+      params.append('preselected-ns', ns);
+      break;
+    case ImportOptions.CATALOG:
+      pageUrl = '/catalog';


Missing the namespace?

Suggested change

pageUrl = '/catalog';

pageUrl = `/catalog/ns/${ns}`;

christianvogt · 2020-01-20T16:20:07Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+      break;
+    case ImportOptions.CONTAINER:
+      pageUrl = `/deploy-image/ns/${ns}`;
+      params.append('preselected-ns', ns);


What is preselected-ns used that the namespace in the URL path cannot be used for?

Followed the EmptyState navigation url, but it looks like namespace in the url is enough,so removed this query params

christianvogt · 2020-01-20T17:26:07Z

frontend/packages/dev-console/src/actions/add-resources.tsx

+export const fromGit = createKebabAction('From Git', <GitAltIcon />, ImportOptions.GIT);
+export const containerImage = createKebabAction(


nit: can we add an empty line between each export.
Not a big deal since prettier accepts it.

christianvogt · 2020-01-20T17:46:35Z

frontend/packages/dev-console/src/components/topology/actions/graphActions.ts

+  const primaryResource: Node = _.find(elements, {
+    type: TYPE_WORKLOAD,
+  }) as Node;
+  return [...addResourcesMenu(primaryResource.getData())];


catalog and Database don't have rbac checks in the +Add page today.
We should be consistent.

christianvogt · 2020-01-20T17:50:21Z

frontend/packages/dev-console/src/components/topology/nodeContextMenu.tsx

 const nodeContextMenu = (element: Node) =>
  createMenuItems(kebabOptionsToMenu(nodeActions(element.getData())));

-export { workloadContextMenu, groupContextMenu, nodeContextMenu };


Don't look at me... Jeff did it :P

christianvogt · 2020-01-20T17:51:49Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+  switch (type) {
+    case ImportOptions.GIT:
+      pageUrl = `/import/ns/${ns}`;
+      params.append('importType', 'git');


We should probably assume that no importType defaults to git? It's ok to also handle being explicit.

christianvogt · 2020-01-20T17:52:25Z

frontend/packages/dev-console/src/utils/add-resources-menu-utils.ts

+  if (!hasApplication || !appGroup) {
+    return `${pageUrl}?${params.toString()}`;
+  }
+  params.append('application', encodeURIComponent(appGroup));
+  return `${pageUrl}?${params.toString()}`;


Simplify so that there's only a single return statement.

christianvogt · 2020-01-20T19:42:37Z

/approve
I haven't yet run this until I get my temp laptop setup.

karthikjeeyar · 2020-01-20T19:55:48Z

/test analyze

vikram-raj

Tested locally. The setting of the application context in the add form is not working as this work is done in this PR #3958.

/lgtm

openshift-ci-robot · 2020-01-21T06:54:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-21T06:55:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2020

openshift-ci-robot requested review from divyanshiGupta and jcaianirh January 10, 2020 16:45

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console labels Jan 10, 2020

andrewballantyne reviewed Jan 10, 2020

View reviewed changes

christianvogt mentioned this pull request Jan 11, 2020

add submenu support to resource action menus #3922

Merged

karthikjeeyar changed the title ~~feat(topology-resourcemenu): add resource menu actions~~ WIP: feat(topology-resourcemenu): add resource menu actions Jan 13, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2020

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 13, 2020

karthikjeeyar force-pushed the add-resource-menu branch 3 times, most recently from fb7676a to 7fb6858 Compare January 14, 2020 08:15

karthikjeeyar changed the title ~~WIP: feat(topology-resourcemenu): add resource menu actions~~ feat(topology-resourcemenu): add resource menu actions Jan 14, 2020

andrewballantyne mentioned this pull request Jan 14, 2020

Service Binding From Add Flow #3958

Merged

5 tasks

andrewballantyne suggested changes Jan 15, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Jan 15, 2020

karthikjeeyar force-pushed the add-resource-menu branch from 7fb6858 to d5b93a6 Compare January 16, 2020 15:22

andrewballantyne suggested changes Jan 16, 2020

View reviewed changes

karthikjeeyar force-pushed the add-resource-menu branch from d5b93a6 to 1dc4218 Compare January 16, 2020 17:29

andrewballantyne suggested changes Jan 16, 2020

View reviewed changes

karthikjeeyar force-pushed the add-resource-menu branch from 1dc4218 to e938b38 Compare January 17, 2020 04:39

karthikjeeyar force-pushed the add-resource-menu branch from e938b38 to 6b570f9 Compare January 17, 2020 05:30

karthikjeeyar force-pushed the add-resource-menu branch from 6b570f9 to 8e11037 Compare January 17, 2020 06:15

andrewballantyne approved these changes Jan 17, 2020

View reviewed changes

openshift-ci-robot assigned christianvogt Jan 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020

nemesis09 mentioned this pull request Jan 19, 2020

feat(topology): add new service in context #3979

Merged

karthikjeeyar closed this Jan 20, 2020

karthikjeeyar reopened this Jan 20, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020

christianvogt reviewed Jan 20, 2020

View reviewed changes

feat(topology-resourcemenu): add resource menu actions

45f8300

karthikjeeyar force-pushed the add-resource-menu branch from 8e11037 to 45f8300 Compare January 20, 2020 19:04

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020

vikram-raj reviewed Jan 21, 2020

View reviewed changes

openshift-ci-robot assigned vikram-raj Jan 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-merge-robot merged commit fb0a5b2 into openshift:master Jan 21, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

	return `${pageUrl}${seperator}component=${obj.metadata.name}&isKnativeDisabled=${obj.kind ===
	return `${pageUrl}${seperator}component=${encodeURIComponent(obj.metadata.name)}&isKnativeDisabled=${obj.kind ===

	export const FromGit = (obj?: K8sResourceKind, hasApplication?: boolean): KebabOption => {
	export const fromGit = (obj?: K8sResourceKind, hasApplication?: boolean): KebabOption => {

	export const fromGit = createKebabOption('From Git', <GitAltIcon />, ImportOptions.GIT);
	export const fromGit = createKebabAction('From Git', <GitAltIcon />, ImportOptions.GIT);

	export const database = createKebabOption('Database', <DatabaseIcon />, ImportOptions.DATABASE);
	export const fromDatabaseCatalog = createKebabOption('Database', <DatabaseIcon />, ImportOptions.DATABASE);

		@@ -0,0 +1,131 @@
		import { URL } from 'url';
		import { getMenuPath, getAddPageUrl } from '../add-resources-menu-utils';

		expect(url.searchParams.has('preselected-ns')).toBe(false);
		expect(url.searchParams.has('catagory')).toBe(false);

		export const fromGit = createKebabAction('From Git', <GitAltIcon />, ImportOptions.GIT);
		export const containerImage = createKebabAction(

feat(topology-resourcemenu): add resource menu actions #3918

feat(topology-resourcemenu): add resource menu actions #3918

Conversation

karthikjeeyar commented Jan 10, 2020 • edited

Choose a reason for hiding this comment

christianvogt commented Jan 11, 2020

karthikjeeyar commented Jan 13, 2020

andrewballantyne commented Jan 13, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne Jan 14, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karthikjeeyar Jan 16, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne commented Jan 15, 2020

karthikjeeyar commented Jan 16, 2020

andrewballantyne commented Jan 16, 2020 • edited

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne commented Jan 16, 2020

karthikjeeyar commented Jan 17, 2020

karthikjeeyar commented Jan 17, 2020

invincibleJai commented Jan 17, 2020

andrewballantyne commented Jan 17, 2020

serenamarie125 commented Jan 19, 2020

karthikjeeyar commented Jan 20, 2020 • edited

karthikjeeyar commented Jan 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianvogt commented Jan 20, 2020

karthikjeeyar commented Jan 20, 2020

vikram-raj left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

karthikjeeyar commented Jan 10, 2020 •

edited

andrewballantyne Jan 14, 2020 •

edited

karthikjeeyar Jan 16, 2020 •

edited

andrewballantyne commented Jan 16, 2020 •

edited

karthikjeeyar commented Jan 20, 2020 •

edited