Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make operator logo as default if the service is operator backed #3919

Merged
merged 1 commit into from Jan 11, 2020
Merged

Make operator logo as default if the service is operator backed #3919

merged 1 commit into from Jan 11, 2020

Conversation

rohitkrai03
Copy link
Contributor

Related Story - https://issues.redhat.com/browse/ODC-2455

This PR -

  • Updates the default icon behaviour of topology workloads based on the changed AC of the story.
  • So, no if the workload is operator backed then CSV icon or default operator icon will be shown. Otherwise builder image icon or default openshift icon will be shown.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/dev-console Related to dev-console component/shared Related to console-shared labels Jan 10, 2020
@christianvogt
Copy link
Contributor

@rohitkrai03 we want to do this: builderImage: builderImageIcon || csvIcon || defaultIcon

@rohitkrai03
Copy link
Contributor Author

@rohitkrai03 we want to do this: builderImage: builderImageIcon || csvIcon || defaultIcon

Done.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2020
@rohitkrai03
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 06fe32b into openshift:master Jan 11, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 14, 2020
@rohitkrai03 rohitkrai03 deleted the show-csv-icon branch March 30, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohitkrai03 @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot