Bug 1808280: Add edit application feature for apps created using deploy image flow

[divyanshiGupta]

Jira Story - https://issues.redhat.com/browse/ODC-2347

This PR adds:

• Edit Application feature for applications created using deploy image flow
• Changes according to latest UX (Modal is replaced with a page and some other changes).
• Fixes bug wherein in deploy image new image stream is created in case of internal registry and resource type being knative, when the image stream already existsn and new imageStream dockerImageRepo was being set in knativeService instead of the existing one and hence the revision gets failed because the imageStream cant be fetched.

Image from external registry -

Image from internal registry -

To do -

• Populate internal registry fields

• Unit tests

@openshift/team-devconsole-ux

[divyanshiGupta]

/kind feature

[divyanshiGupta]

/retest

[serenamarie125]

@divyanshiGupta this is looking good!

Can you check the following situations

• if there is an existing route, the user should not be able to deselect that box to remove it
• if there is no existing route, the user should be able to select the box to create one

I can't tell if those are covered specifically in those animated gifs! Thank you!

[divyanshiGupta]

@divyanshiGupta this is looking good!

Can you check the following situations

• if there is an existing route, the user should not be able to deselect that box to remove it
• if there is no existing route, the user should be able to select the box to create one

I can't tell if those are covered specifically in those animated gifs! Thank you!

Yes, @serenamarie125 I have added the scenario you mentioned. This scenario is already there since edit from git and dockerfile is in master.

[rohitkrai03]

@divyanshiGupta You should run linter after doing clean yarn install. There were some linter rule changes recently.

[karthikjeeyar]

@divyanshiGupta While editing an internal registry application, Imagestream tag is not preselected, it has dropdown items but shows No Tag. Please confirm, if you have seeing it.

[karthikjeeyar]

run ./build.sh or remove node_modules and do yarn install && yarn lint --fix to fix the lint issues.

[rohitkrai03]

/lgtm

[divyanshiGupta]

/assign @christianvogt

[divyanshiGupta]

/retest

[christianvogt]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/hold
the merge queue is blocked

[spadgett]

/hold cancel

[invincibleJai]

/retitle Bug 1808280: Add edit application feature for apps created using deploy image flow

[openshift-ci-robot]

@divyanshiGupta: All pull requests linked via external trackers have merged. Bugzilla bug 1808280 has been moved to the MODIFIED state.

In response to this:

Bug 1808280: Add edit application feature for apps created using deploy image flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

This PR's commit 6f04e4f , tries to address issue with https://bugzilla.redhat.com/show_bug.cgi?id=1808280