Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1786068: Bug 1786070: Bug 1786091: Fixes kubevirt cdrom bugs #3933

Merged
merged 1 commit into from Jan 15, 2020
Merged

Bug 1786068: Bug 1786070: Bug 1786091: Fixes kubevirt cdrom bugs #3933

merged 1 commit into from Jan 15, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Jan 13, 2020

  • CD Deletion now happens only after submitting
  • Removed Eject mechanism
  • Set Hover delay of max cd tooltip to 0

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1786068
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1786070
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1786091

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Jan 13, 2020
glekner
glekner commented Jan 13, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/k8s/patches/vm/vm-cdrom-patches.ts
let VOLS = getVolumes(asVM(vm));
let DATATEMPLATES = getDataVolumeTemplates(asVM(vm));
const storageClassConfigMap = await getStorageClassConfigMap({ k8sGet });

cds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Reviewers
The only change here is removal of cds.filter((cd) => cd.changed)

@yaacov
Copy link
Member

yaacov commented Jan 13, 2020

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2020
@glekner glekner changed the title Bug 1786068, 1786070, 1786091: Fixes kubevirt cdrom bugs Bug 1786068, Bug 1786070, Bug 1786091: Fixes kubevirt cdrom bugs Jan 13, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1786091, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1786068, Bug 1786070, Bug 1786091: Fixes kubevirt cdrom bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 13, 2020
@glekner
Copy link
Contributor Author

glekner commented Jan 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1786091, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glekner glekner changed the title Bug 1786068, Bug 1786070, Bug 1786091: Fixes kubevirt cdrom bugs Bug 1786068: Bug 1786070: Bug 1786091: Fixes kubevirt cdrom bugs Jan 13, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1786068, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1786068: Bug 1786070: Bug 1786091: Fixes kubevirt cdrom bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Jan 13, 2020

/lgtm
+1 on the red/green ratio

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@yaacov
Copy link
Member

yaacov commented Jan 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glekner
Copy link
Contributor Author

glekner commented Jan 15, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1786068, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit c2e80a9 into openshift:master Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: All pull requests linked via external trackers have merged. Bugzilla bug 1786068 has been moved to the MODIFIED state.

In response to this:

Bug 1786068: Bug 1786070: Bug 1786091: Fixes kubevirt cdrom bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glekner @yaacov @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot