Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Overview pages to Details pages #3934

Merged
merged 1 commit into from Jan 22, 2020
Merged

Rename Overview pages to Details pages #3934

merged 1 commit into from Jan 22, 2020

Conversation

rawagner
Copy link
Contributor

Rename Dashboards page to Overview
Rename Overview Dashboard page to Cluster

overview_details_2
overview_details_1

@andybraren @spadgett

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2020
spadgett
spadgett reviewed Jan 13, 2020
View reviewed changes
frontend/public/components/app-contents.tsx Outdated
@@ -115,7 +115,7 @@ const AppContents_: React.FC<AppContentsProps> = ({ activePerspective, flags })

<Route path={['/all-namespaces', '/ns/:ns']} component={RedirectComponent} />
<LazyRoute
path="/dashboards"
path="/overview"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm undecided on this because it will break old links to old route /overview/:namespace, which used to be the project overview. We might leave the URL as-is and just update the labels in the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @rawagner after some more discussion I think we've agreed to not break the URL right now to avoid bookmarks going to a weird place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the change to url was removed

@andybraren
Copy link
Contributor

andybraren commented Jan 13, 2020 •
edited

Thank you @rawagner! Some more images of how this affects resource pages for reference:

Workload (Pod) page

image

Build Config page (Dev perspective)

image

Monitoring page (Dev perspective)

With slightly modified tab labels based on @cshinn's latest designs.

image

Project page (Dev perspective)

image

@rawagner rawagner force-pushed the overview_details branch 2 times, most recently from 9114e78 to d8d310b Compare January 14, 2020 14:09
spadgett
spadgett approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks, feel free to remove WIP when ready

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 14, 2020
andybraren
andybraren approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@andybraren andybraren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got approval from stakeholders on the Admin & Dev sides - I think this is good to go. 👍

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@rawagner rawagner changed the title [WIP] Rename Overview pages to Details pages Rename Overview pages to Details pages Jan 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2020
@rawagner
Copy link
Contributor Author

@spadgett I had to rebase, can you lgtm again ? I didnt find any issues so far so removing WIP.

@rawagner rawagner force-pushed the overview_details branch 3 times, most recently from faeaa99 to 759a45c Compare January 17, 2020 08:08
@rawagner
Copy link
Contributor Author

/retest

1 similar comment
@rawagner
Copy link
Contributor Author

/retest

@benjaminapetersen
Copy link
Contributor

/lgtm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kyoto
Copy link
Member

kyoto commented Jan 21, 2020

/lgtm cancel

@rawagner Looks like you need to update the Monitoring tests to expect Details instead of Overview

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@rawagner
Copy link
Contributor Author

/retest

1 similar comment
@rawagner
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor Author

@kyoto fixed the monitoring tests

@kyoto
Copy link
Member

kyoto commented Jan 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2020
@rawagner
Copy link
Contributor Author

/hold

needs rebase again

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@rawagner
Rename Overview pages to Details pages
fe2c461 
Rename Dashboards page to Overview
Rename Overview Dashboard page to Cluster
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 22, 2020
@rawagner
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, benjaminapetersen, kyoto, rawagner, spadgett, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett mentioned this pull request Jan 22, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit 6cd4ee3 into openshift:master Jan 22, 2020
This was referenced Feb 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@andybraren andybraren andybraren approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@benjaminapetersen benjaminapetersen

@kyoto kyoto

@spadgett spadgett

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rawagner @andybraren @benjaminapetersen @openshift-bot @spadgett @kyoto @atiratree @openshift-ci-robot @openshift-merge-robot