Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-vm-wizard so it won't stall on pulling templates #3935

Merged
merged 1 commit into from Jan 14, 2020
Merged

Fix create-vm-wizard so it won't stall on pulling templates #3935

merged 1 commit into from Jan 14, 2020

Conversation

irosenzw
Copy link
Contributor

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Jan 13, 2020
@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@irosenzw irosenzw force-pushed the fix-vm-wizard-infinite-loading branch from 582e86c to 760a5bc Compare January 13, 2020 19:16
@irosenzw irosenzw changed the title Fix create-vm-wizard so it won't stuck on pulling templates Fix create-vm-wizard so it won't stall on pulling templates Jan 13, 2020
@irosenzw
Fix create-vm-wizard so it won't stall on pulling templates
0294d5a 
Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@irosenzw irosenzw force-pushed the fix-vm-wizard-infinite-loading branch from 760a5bc to 0294d5a Compare January 14, 2020 07:42
@irosenzw
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea28f24 into openshift:master Jan 14, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@irosenzw @atiratree @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot