New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActionFeatureFlag extension #3936
Add ActionFeatureFlag extension #3936
Conversation
cc @spadgett There are currently two use cases for this type of extension:
|
/retest |
1 similar comment
/retest |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtomasek, rawagner, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makes sense, thanks @vojtechszocs Related to this, we should look at adding a SelfSubjectAccessReview flag for detecting the user's permissions. For instance, to only show a nav item when the user can list the resource. It's needed for OLM, but I think it would be generally useful. (As a follow-on, not this PR.) |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR allows extending
detectFeatures
inpublic/actions/features.ts
module.Existing
setFlag
andhandleError
functions should be reused when implementing detection of new, plugin-specific features.cc @christianvogt @jtomasek @bipuladh