Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActionFeatureFlag extension #3936

Merged

Conversation

vojtechszocs
Copy link
Contributor

This PR allows extending detectFeatures in public/actions/features.ts module.

Existing setFlag and handleError functions should be reused when implementing detection of new, plugin-specific features.

cc @christianvogt @jtomasek @bipuladh

@vojtechszocs vojtechszocs mentioned this pull request Jan 13, 2020
1 task
@vojtechszocs
Copy link
Contributor Author

cc @spadgett

There are currently two use cases for this type of extension:

  • ocs-independent-plugin (Independent Mode Dashboard #3907) - detect specific instance of OCSServiceModel
  • metal3-plugin - move detectBaremetalPlatform from public/actions/features.ts to plugin

@vojtechszocs
Copy link
Contributor Author

/retest

1 similar comment
@vojtechszocs
Copy link
Contributor Author

/retest

@jtomasek
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

Makes sense, thanks @vojtechszocs

Related to this, we should look at adding a SelfSubjectAccessReview flag for detecting the user's permissions. For instance, to only show a nav item when the user can list the resource. It's needed for OLM, but I think it would be generally useful. (As a follow-on, not this PR.)

@spadgett spadgett added this to the v4.4 milestone Jan 14, 2020
@spadgett
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 770b7bc into openshift:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants