Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790528: Make subscriptions & catalog sources optional so normal users can see installed operators #3940

Conversation

benjaminapetersen
Copy link
Contributor

Related to:

Will need to cherry-pick to 4.3 to address the above bug.

Brings us from:

Screen Shot 2020-01-13 at 3 59 37 PM

to:

Screen Shot 2020-01-13 at 3 58 56 PM

@benjaminapetersen
Copy link
Contributor Author

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM labels Jan 13, 2020
@spadgett
Copy link
Member

@benjaminapetersen benjaminapetersen force-pushed the release/4.4/bug/1790528/normal-user-cannot-see-and-use-installed-operators branch from 4ab978f to e8ba340 Compare January 13, 2020 21:07
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2020
@spadgett spadgett force-pushed the release/4.4/bug/1790528/normal-user-cannot-see-and-use-installed-operators branch from fc0ea0c to 10d7958 Compare January 13, 2020 21:44
@spadgett
Copy link
Member

/retest

@spadgett spadgett force-pushed the release/4.4/bug/1790528/normal-user-cannot-see-and-use-installed-operators branch from 10d7958 to 3913c1c Compare January 14, 2020 13:13
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 14, 2020
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/test analyze

@spadgett
Copy link
Member

/assign @rhamilto

@rhamilto would be good for you to review since @benjaminapetersen and I both have commits

@rhamilto
Copy link
Member

/lgtm

catalogSourceMissing is an odd prop name, but I don't have a better suggestion.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 928da59 into openshift:master Jan 14, 2020
@spadgett
Copy link
Member

/cherry-pick release-4.3

@openshift-cherrypick-robot

@spadgett: new pull request created: #3963

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett changed the title Make subscriptions & catalog sources optional so normal users can see installed operators Bug 1790528: Make subscriptions & catalog sources optional so normal users can see installed operators Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1790528 has been moved to the MODIFIED state.

In response to this:

Bug 1790528: Make subscriptions & catalog sources optional so normal users can see installed operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benjaminapetersen benjaminapetersen deleted the release/4.4/bug/1790528/normal-user-cannot-see-and-use-installed-operators branch January 15, 2020 14:53
@spadgett
Copy link
Member

/bugzilla refresh

@spadgett spadgett added this to the v4.4 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants