add Managed by section in resource tab for operator backed services #3943

nemesis09 · 2020-01-14T07:44:07Z

This PR-

adds a Managed by operator section in the resource tab for operator backed services
is tracked by issue https://issues.redhat.com/browse/ODC-2700
screens-

andrewballantyne · 2020-01-15T01:23:10Z

/kind feature

nemesis09 · 2020-01-16T13:35:04Z

putting on hold as UXD is yet to be confirmed.
/hold

nemesis09 · 2020-01-16T13:46:15Z

removing hold as we are going with the presently available UXD option for the time being.
/hold cancel

nemesis09 · 2020-01-16T13:46:38Z

/retest

rohitkrai03 · 2020-01-17T14:18:39Z

frontend/packages/knative-plugin/src/components/overview/OverviewDetailsKnativeResourcesTab.tsx

@@ -45,6 +46,18 @@ const getSidebarResources = ({ obj, ksroutes, revisions, configurations }: Overv
 };
 const OverviewDetailsKnativeResourcesTab: React.FC<OverviewDetailsResourcesTabProps> = ({
  item,
-}) => <div className="overview__sidebar-pane-body"> {getSidebarResources(item)} </div>;
+}) => (
+  <div className="overview__sidebar-pane-body">


I see the same code repeated twice. Make this a pure component and share it in both places.

rohitkrai03 · 2020-01-17T14:19:03Z

frontend/public/components/overview/resource-overview-page.tsx

@@ -34,6 +40,14 @@ export const OverviewDetailsResourcesTab: React.SFC<OverviewDetailsResourcesTabP
  const pluginComponents = getPluginTabSectionResource(item);
  return (
    <div className="overview__sidebar-pane-body">
+      {item.isOperatorBackedService && (


Use shared component.

christianvogt · 2020-01-17T14:45:06Z

frontend/packages/knative-plugin/src/components/overview/OverviewDetailsKnativeResourcesTab.tsx

+      <span className="sidebar__section-owner-operator-heading">
+        Managed by operator:
+        <span className="sidebar__section-owner-reference-operator">
+          <OwnerReferences resource={item.obj} />


Looks like owner references can be an array. Does this mean that every owner ref should be listed or only the one that is backed by an operator?
Reusing this component is probably ok for now but we should ok investigate.

in case of multiple owners, we could have a check for the operator backed owner.
I'm not sure if there can be multiple operator backed owners.

christianvogt · 2020-01-21T02:21:22Z

frontend/public/components/utils/operator-backed-owner-references.tsx

+import { OverviewItem } from '@console/shared';
+import { OwnerReferences } from './owner-references';
+
+export const OperatorBackedOwnerReferences: React.FC<OperatorBackedOwnerReferencesProps> = ({


We prefer single default exports for component files.

I've updated the component to export default OperatorBackedOwnerReferences.
PTAL

jeff-phillips-18 · 2020-01-21T11:40:51Z

@openshift/team-devconsole-ux

nemesis09 · 2020-01-22T14:37:53Z

/retest

nemesis09 · 2020-01-22T16:10:18Z

/test images
/test e2e-gcp-console

serenamarie125

looks good!

christianvogt · 2020-01-23T22:50:50Z

The data in topology and list view differs.
I suppose we could fix the list view as a followup bug.

Topology:

List view:

christianvogt · 2020-01-23T22:51:11Z

/approve

karthikjeeyar · 2020-01-24T05:36:50Z

/test images

karthikjeeyar · 2020-01-24T07:29:42Z

Knative Services are not considered as operator backed (sidepanel does not have managed by: knative serving operator), we need to show the knative opertaor Icon. we can have a followup bug for this and displaying operator icon.

cc: @christianvogt @nemesis09

karthikjeeyar · 2020-01-24T07:30:11Z

Verified locally
/lgtm

openshift-ci-robot · 2020-01-24T07:30:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar, nemesis09, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nemesis09 · 2020-01-24T07:41:24Z

Knative Services are not considered as operator backed (sidepanel does not have managed by: knative serving operator), we need to show the knative opertaor Icon. we can have a followup bug for this and displaying operator icon.

cc: @christianvogt @nemesis09

That would require the isOperatorBackedService flag to be set to true in topology. owner reference for knative operator is also absent. these changes can be made as a part of the bug.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2020

openshift-ci-robot requested review from abhi-kn and divyanshiGupta January 14, 2020 07:44

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared labels Jan 14, 2020

nemesis09 force-pushed the identify-operator-backed-sidebar branch from 10e93dc to 96c1761 Compare January 14, 2020 16:41

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2020

nemesis09 changed the title ~~[WIP] add Managed by section in resource tab for operator backed services~~ add Managed by section in resource tab for operator backed services Jan 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020

rohitkrai03 suggested changes Jan 17, 2020

View reviewed changes

christianvogt reviewed Jan 17, 2020

View reviewed changes

nemesis09 force-pushed the identify-operator-backed-sidebar branch 3 times, most recently from eb0dc03 to 8e0b72a Compare January 21, 2020 01:59

christianvogt reviewed Jan 21, 2020

View reviewed changes

nemesis09 force-pushed the identify-operator-backed-sidebar branch 4 times, most recently from addc645 to 5b92772 Compare January 22, 2020 14:01

nemesis09 force-pushed the identify-operator-backed-sidebar branch from 5b92772 to 22e6cba Compare January 22, 2020 15:52

serenamarie125 approved these changes Jan 23, 2020

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020

nemesis09 force-pushed the identify-operator-backed-sidebar branch from 22e6cba to 5586c2b Compare January 24, 2020 03:17

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020

add owner section in resource tab for operator backed services

fa97c2b

nemesis09 force-pushed the identify-operator-backed-sidebar branch from 5586c2b to fa97c2b Compare January 24, 2020 05:51

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020

openshift-ci-robot assigned karthikjeeyar Jan 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

openshift-merge-robot merged commit a7a1b57 into openshift:master Jan 24, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Managed by section in resource tab for operator backed services #3943

add Managed by section in resource tab for operator backed services #3943

nemesis09 commented Jan 14, 2020

andrewballantyne commented Jan 15, 2020

nemesis09 commented Jan 16, 2020

nemesis09 commented Jan 16, 2020

nemesis09 commented Jan 16, 2020

rohitkrai03 Jan 17, 2020

rohitkrai03 Jan 17, 2020

nemesis09 Jan 20, 2020

christianvogt Jan 17, 2020

nemesis09 Jan 20, 2020 •

edited

christianvogt Jan 21, 2020

nemesis09 Jan 22, 2020

jeff-phillips-18 commented Jan 21, 2020

nemesis09 commented Jan 22, 2020

nemesis09 commented Jan 22, 2020

serenamarie125 left a comment

christianvogt commented Jan 23, 2020

christianvogt commented Jan 23, 2020

karthikjeeyar commented Jan 24, 2020

karthikjeeyar commented Jan 24, 2020

karthikjeeyar commented Jan 24, 2020

openshift-ci-robot commented Jan 24, 2020

nemesis09 commented Jan 24, 2020

add Managed by section in resource tab for operator backed services #3943

add Managed by section in resource tab for operator backed services #3943

Conversation

nemesis09 commented Jan 14, 2020

andrewballantyne commented Jan 15, 2020

nemesis09 commented Jan 16, 2020

nemesis09 commented Jan 16, 2020

nemesis09 commented Jan 16, 2020

rohitkrai03 Jan 17, 2020

Choose a reason for hiding this comment

rohitkrai03 Jan 17, 2020

Choose a reason for hiding this comment

nemesis09 Jan 20, 2020

Choose a reason for hiding this comment

christianvogt Jan 17, 2020

Choose a reason for hiding this comment

nemesis09 Jan 20, 2020 • edited

Choose a reason for hiding this comment

christianvogt Jan 21, 2020

Choose a reason for hiding this comment

nemesis09 Jan 22, 2020

Choose a reason for hiding this comment

jeff-phillips-18 commented Jan 21, 2020

nemesis09 commented Jan 22, 2020

nemesis09 commented Jan 22, 2020

serenamarie125 left a comment

Choose a reason for hiding this comment

christianvogt commented Jan 23, 2020

christianvogt commented Jan 23, 2020

karthikjeeyar commented Jan 24, 2020

karthikjeeyar commented Jan 24, 2020

karthikjeeyar commented Jan 24, 2020

openshift-ci-robot commented Jan 24, 2020

nemesis09 commented Jan 24, 2020

nemesis09 Jan 20, 2020 •

edited