Monitoring Dashboards: Add variable dropdowns #3946
Conversation
Use the dashboard JSON definition's `templating` sections to generate dropdowns for the dashboard variables.
openshift-ci-robot
added
size/L
openshift-ci-robot
added
the
approved
|
/test analyze |
| }) => ( | ||
| <div className="monitoring-dashboards__dropdown-wrap"> | ||
| {title && <h4>{title}</h4>} | ||
| <Dropdown |
There was a problem hiding this comment.
Do we ever want this to be a filtering select?
| parsePrometheusDuration(defaultPollInterval), | ||
| ); | ||
| const [timespan, setTimespan] = React.useState(parsePrometheusDuration(defaultTimespan)); | ||
| const [timespan, setTimespan] = React.useState<number>(parsePrometheusDuration(defaultTimespan)); |
There was a problem hiding this comment.
If parsePrometheusDuration has a return type, the type should be inferred
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test analyze |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/refresh |
Use the dashboard JSON definition's
templatingsections to generatedropdowns for the dashboard variables.
This PR does not handle the case where a variable's
querycontains the another variable. That will be addressed with a separate PR.