Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790528: Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi… #3984

Conversation

benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Jan 16, 2020

Reverts the removal of OPERATOR_LIFECYCLE_MANAGER flag from OLM plugin so that the dev catalog can show content.

Before:

Screen Shot 2020-01-16 at 12 33 33 PM

After:

Screen Shot 2020-01-16 at 12 26 09 PM

For all interested:
/assign @spadgett @jeff-phillips-18 @andrewballantyne

With hopes that this one stirs up efforts for at least basic test coverage where possible.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM labels Jan 16, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@spadgett spadgett changed the title Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi… Bug 1790528: Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi… Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1790528, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1790528: Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 16, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, benjaminapetersen, jeff-phillips-18, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor

/retest

1 similar comment
@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 02d1610 into openshift:master Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1790528 has been moved to the MODIFIED state.

In response to this:

Bug 1790528: Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants