New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1790528: Fix removal of OPERATOR_LIFECYCLE_MANAGER flag from olm package causi… #3984
Conversation
…ng dev catalog to not load content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
@benjaminapetersen: This pull request references Bugzilla bug 1790528, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, benjaminapetersen, jeff-phillips-18, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1790528 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverts the removal of
OPERATOR_LIFECYCLE_MANAGER
flag from OLM plugin so that the dev catalog can show content.Before:
After:
For all interested:
/assign @spadgett @jeff-phillips-18 @andrewballantyne
With hopes that this one stirs up efforts for at least basic test coverage where possible.