Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host status refactoring #3989

Merged
merged 1 commit into from Jan 22, 2020
Merged

Host status refactoring #3989

merged 1 commit into from Jan 22, 2020

Conversation

jtomasek
Copy link

@jtomasek jtomasek commented Jan 16, 2020 •
edited

Depends on #3964

  • Define bare metal host status and errors descriptions in constants
  • Pass status description as part of getBareMetalHostStatus helper
  • Simplify BareMetalHostStatus logic
  • Render status descriptions in status popovers
  • Render error status descriptions in status popover together with
    detailed error message
  • Remove unused bare metal host states

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/metal3 Related to metal3-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2020
Clean up baremetal host states
c4f56be 
- Define bare metal host status and errors descriptions in constants
- Pass status description as part of getBareMetalHostStatus helper
- Simplify BareMetalHostStatus logic
- Render status descriptions in status popovers
- Render error status descriptions in status popover together with
  detailed error message
- Remove unused bare metal host states
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jelkosz
Copy link

jelkosz commented Jan 21, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
the merge queue is blocked

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit db1aa22 into openshift:master Jan 22, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flofuchs flofuchs Awaiting requested review from flofuchs

@honza honza Awaiting requested review from honza

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jtomasek @rawagner @openshift-ci-robot @openshift-bot @jelkosz @spadgett @openshift-merge-robot