New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797460: Fix view more button padding for cluster update message #3994
Bug 1797460: Fix view more button padding for cluster update message #3994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better to me 🙂
/assign @rhamilto |
/kind bug |
@rawagner: This pull request references Bugzilla bug 1797460, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7dc3901
to
3a9e78d
Compare
3a9e78d
to
924df57
Compare
/retest |
@@ -101,11 +101,7 @@ const ClusterAlerts = connectToFlags(FLAGS.OPENSHIFT)( | |||
const cvLoaded = _.get(resources.cv, 'loaded'); | |||
const LinkComponent = React.useCallback( | |||
() => ( | |||
<Button | |||
className="co-status-card__link-button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this class is no longer being used and should be removed from https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/components/dashboard/status-card/status-card.scss#L97-L99
924df57
to
766d505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andybraren, rawagner, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1797460 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before - view more for cluster update message in status card is misaligned
After