metal3: support edit for Bare Metal Hosts #3998

atiratree · 2020-01-17T21:04:28Z

depends on

atiratree · 2020-01-17T21:11:39Z

design

jtomasek · 2020-01-20T10:13:40Z

...ackages/metal3-plugin/src/components/baremetal-hosts/add-baremetal-host/AddBareMetalHost.tsx

+        validationSchema={addHostValidationSchema}
+        component={AddBareMetalHostForm}
+        isNameDisabled={isEditing}
+      />


The context is not needed. By using children instead of component prop, it is possible to pass additional props.

Suggested change

/>

>

{(props) => (

<AddBareMetalHostForm {...props} showUpdated={showUpdated} isEditing={isEditing} />

)}

</Formik>

jtomasek · 2020-01-20T10:14:48Z

...ges/metal3-plugin/src/components/baremetal-hosts/add-baremetal-host/AddBareMetalHostForm.tsx

-  </Form>
-);
+}) => {
+  const { isNameDisabled, isEditing, showUpdated } = React.useContext<any>(AddBareMetalHostContext);


Not needed with the change described above.

jtomasek · 2020-01-20T10:17:11Z

...ges/metal3-plugin/src/components/baremetal-hosts/add-baremetal-host/AddBareMetalHostForm.tsx

+        placeholder="openshift-worker"
+        helpText="Provide unique name for the new Bare Metal Host."
+        required
+        isDisabled={isNameDisabled}


Since isEditing is used to toggle parts of the form in case of editing, using isNameDisabled is not needed and can be replaced by isEditing

jtomasek · 2020-01-20T10:20:09Z

frontend/packages/metal3-plugin/src/k8s/objects/bare-metal-host.ts

@@ -13,8 +12,8 @@ export const buildBareMetalHostSecret = (name, namespace, username, password) =>
    name: getSecretName(name),
  },
  data: {
-    username: Base64.encode(username),
-    password: Base64.encode(password),
+    username: btoa(username),


I think I used Base64.encode to be in sync with the way it is done in the secrets codebase, but no big deal.

I used these because it is more straightforward solution

jtomasek · 2020-01-20T10:25:24Z

frontend/packages/metal3-plugin/src/selectors/secret.ts

@@ -0,0 +1,6 @@
+import { K8sResourceKind } from '@console/internal/module/k8s';


This file should go in @console/shared but I am fine with doing it in a follow up.

jtomasek · 2020-01-20T10:27:58Z

frontend/packages/metal3-plugin/src/utils/index.ts

+import { FirehoseResult } from '@console/internal/components/utils';
+import { K8sResourceKind } from '@console/internal/module/k8s';
+
+export const getLoadedData = (


This should go to @console/shared as well, in a follow up patch is fine.

ok, let's move these later. This function is used in many places in kubevirt.

atiratree · 2020-01-20T16:55:56Z

fixed: using inline funciton instead of a context

jtomasek · 2020-01-21T08:39:44Z

/lgtm

atiratree · 2020-01-21T09:29:32Z

rebased

jtomasek · 2020-01-21T09:34:27Z

/lgtm

jelkosz · 2020-01-21T11:08:50Z

/test e2e-gcp-console

jelkosz · 2020-01-21T12:38:25Z

/test e2e-gcp-console

openshift-bot · 2020-01-21T14:04:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T14:31:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T14:56:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

atiratree · 2020-01-21T16:49:16Z

/retest

openshift-bot · 2020-01-21T16:53:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

atiratree · 2020-01-21T17:24:51Z

/retest

openshift-bot · 2020-01-21T17:34:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

atiratree · 2020-01-21T19:40:33Z

/retest

openshift-bot · 2020-01-21T20:49:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T22:10:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T23:08:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-01-21T23:16:28Z

/hold
the merge queue is blocked

spadgett · 2020-01-22T01:30:30Z

/hold cancel
/retest

openshift-bot · 2020-01-22T03:10:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T03:23:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T05:07:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T05:20:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jtomasek · 2020-01-22T10:38:58Z

/lgtm

openshift-ci-robot · 2020-01-22T10:39:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/metal3-plugin/OWNERS~~ [jtomasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-22T11:11:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T11:26:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 17, 2020

atiratree mentioned this pull request Jan 17, 2020

bump formik #3999

Merged

openshift-ci-robot added component/metal3 Related to metal3-plugin component/shared Related to console-shared labels Jan 17, 2020

openshift-ci-robot requested review from honza and jhadvig January 17, 2020 21:05

atiratree mentioned this pull request Jan 17, 2020

shared: make alert props optional in FormFooter and update patch #4000

Merged

jtomasek suggested changes Jan 20, 2020

View reviewed changes

atiratree force-pushed the metal.editHostDialog branch from a271690 to a81bc79 Compare January 20, 2020 16:53

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2020

jtomasek approved these changes Jan 21, 2020

View reviewed changes

openshift-ci-robot assigned jtomasek Jan 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

atiratree force-pushed the metal.editHostDialog branch from a81bc79 to 32c1bd8 Compare January 21, 2020 09:29

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

metal3: support edit for Bare Metal Hosts

5ebd000

atiratree force-pushed the metal.editHostDialog branch from 32c1bd8 to 5ebd000 Compare January 22, 2020 10:37

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020

openshift-merge-robot merged commit eb3f27f into openshift:master Jan 22, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

-      />
+      >
+        {(props) => (
+          <AddBareMetalHostForm {...props} showUpdated={showUpdated} isEditing={isEditing} />
+        )}
+      </Formik>

		@@ -0,0 +1,6 @@
		import { K8sResourceKind } from '@console/internal/module/k8s';

metal3: support edit for Bare Metal Hosts #3998

metal3: support edit for Bare Metal Hosts #3998

Conversation

atiratree commented Jan 17, 2020 • edited

atiratree commented Jan 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Jan 20, 2020

jtomasek commented Jan 21, 2020

atiratree commented Jan 21, 2020

jtomasek commented Jan 21, 2020

jelkosz commented Jan 21, 2020

jelkosz commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

atiratree commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

openshift-bot commented Jan 21, 2020

spadgett commented Jan 21, 2020

spadgett commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

jtomasek commented Jan 22, 2020

openshift-ci-robot commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

openshift-bot commented Jan 22, 2020

atiratree commented Jan 17, 2020 •

edited