Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring Dashboards: Add currently displayed dashboard to URL #4005

Merged
merged 1 commit into from Jan 22, 2020
Merged

Monitoring Dashboards: Add currently displayed dashboard to URL #4005

merged 1 commit into from Jan 22, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jan 20, 2020

Also changes the layout of the dropdown options to bring it closer to
the mocks.

Now clears any dashboard data as soon as the current dashboard is
changed, so that all cards from the previous dashboard are immediately
cleared.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring labels Jan 20, 2020
@kyoto kyoto force-pushed the monitoring-dashboards-add-board-to-url branch from 3a35e6f to 4e5d926 Compare January 22, 2020 01:07
@kyoto
Copy link
Member Author

kyoto commented Jan 22, 2020

Rebased and fixed conflict

spadgett
spadgett approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2020
@kyoto
Monitoring Dashboards: Add currently displayed dashboard to URL
676f71a 
Also changes the layout of the dropdown options to bring it closer to
the mocks.

Now clears any dashboard data as soon as the current dashboard is
changed, so that all cards from the previous dashboard are immediately
cleared.
@kyoto kyoto force-pushed the monitoring-dashboards-add-board-to-url branch from 4e5d926 to 676f71a Compare January 22, 2020 05:56
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 22, 2020
@kyoto
Copy link
Member Author

kyoto commented Jan 22, 2020

Rebased again

@kyoto
Copy link
Member Author

kyoto commented Jan 22, 2020

/retest

@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b264785 into openshift:master Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020 •
edited

@kyoto: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/analyze 676f71a link /test analyze

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyoto kyoto deleted the monitoring-dashboards-add-board-to-url branch January 23, 2020 01:12
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-bot @spadgett @openshift-ci-robot @openshift-merge-robot