Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added expand and upgrade activities in persistent storage dashboard #4021

Merged
merged 1 commit into from
Jan 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import DashboardCard from '@console/shared/src/components/dashboard/dashboard-ca
import DashboardCardBody from '@console/shared/src/components/dashboard/dashboard-card/DashboardCardBody';
import DashboardCardHeader from '@console/shared/src/components/dashboard/dashboard-card/DashboardCardHeader';
import DashboardCardTitle from '@console/shared/src/components/dashboard/dashboard-card/DashboardCardTitle';
import { EventKind } from '@console/internal/module/k8s';
import { EventKind, K8sResourceKind } from '@console/internal/module/k8s';
import { FirehoseResource, FirehoseResult } from '@console/internal/components/utils';
import {
EventModel,
Expand All @@ -21,12 +21,35 @@ import {
DashboardItemProps,
withDashboardResources,
} from '@console/internal/components/dashboard/with-dashboard-resources';
import { CEPH_STORAGE_NAMESPACE } from '../../../../constants/index';
import { referenceForModel } from '@console/internal/module/k8s/k8s';
import { SubscriptionModel, SubscriptionKind } from '@console/operator-lifecycle-manager';
import { CEPH_STORAGE_NAMESPACE, OCS_OPERATOR } from '../../../../constants/index';
import { DATA_RESILIENCY_QUERY, StorageDashboardQuery } from '../../../../constants/queries';
import { getResiliencyProgress } from '../../../../utils';
import { OCSServiceModel } from '../../../../models';
import { isClusterExpandActivity, ClusterExpandActivity } from './cluster-expand-activity';
import { isOCSUpgradeActivity, OCSUpgradeActivity } from './ocs-upgrade-activity';
import './activity-card.scss';

const eventsResource: FirehoseResource = { isList: true, kind: EventModel.kind, prop: 'events' };
const subscriptionResource: FirehoseResource = {
isList: true,
kind: referenceForModel(SubscriptionModel),
namespaced: false,
prop: 'subs',
};

const storageClusterResource: FirehoseResource = {
isList: true,
kind: referenceForModel(OCSServiceModel),
namespaced: false,
prop: 'storage-cluster',
};

export const getOCSSubscription = (subscriptions: FirehoseResult): SubscriptionKind => {
const itemsData: K8sResourceKind[] = subscriptions?.data;
return _.find(itemsData, (item) => item?.spec?.name === OCS_OPERATOR) as SubscriptionKind;
};

const ocsEventNamespaceKindFilter = (event: EventKind): boolean =>
getNamespace(event) === CEPH_STORAGE_NAMESPACE ||
Expand All @@ -51,12 +74,24 @@ const RecentEvent = withDashboardResources(
);

const OngoingActivity = withDashboardResources(
({ watchPrometheus, stopWatchPrometheusQuery, prometheusResults }: DashboardItemProps) => {
({
watchPrometheus,
stopWatchPrometheusQuery,
watchK8sResource,
stopWatchK8sResource,
resources,
prometheusResults,
}) => {
React.useEffect(() => {
watchK8sResource(subscriptionResource);
watchK8sResource(storageClusterResource);
watchPrometheus(DATA_RESILIENCY_QUERY[StorageDashboardQuery.RESILIENCY_PROGRESS]);
return () =>
return () => {
stopWatchK8sResource(subscriptionResource);
stopWatchK8sResource(storageClusterResource);
stopWatchPrometheusQuery(DATA_RESILIENCY_QUERY[StorageDashboardQuery.RESILIENCY_PROGRESS]);
}, [watchPrometheus, stopWatchPrometheusQuery]);
};
}, [watchPrometheus, stopWatchPrometheusQuery, watchK8sResource, stopWatchK8sResource]);

const progressResponse = prometheusResults.getIn([
DATA_RESILIENCY_QUERY[StorageDashboardQuery.RESILIENCY_PROGRESS],
Expand All @@ -66,6 +101,15 @@ const OngoingActivity = withDashboardResources(
DATA_RESILIENCY_QUERY[StorageDashboardQuery.RESILIENCY_PROGRESS],
'loadError',
]);

const subscriptions = resources?.subs as FirehoseResult;
const subscriptionsLoaded = subscriptions?.loaded;
const ocsSubscription: SubscriptionKind = getOCSSubscription(subscriptions);

const storageClusters = resources?.['storage-cluster'] as FirehoseResult;
const storageClustersLoaded = storageClusters?.loaded;
const ocsCluster: K8sResourceKind = storageClusters?.data?.[0];

const prometheusActivities = [];
const resourceActivities = [];

Expand All @@ -76,17 +120,33 @@ const OngoingActivity = withDashboardResources(
});
}

if (isOCSUpgradeActivity(ocsSubscription)) {
resourceActivities.push({
resource: ocsSubscription,
timestamp: ocsSubscription?.status?.lastUpdated,
loader: () => Promise.resolve(OCSUpgradeActivity),
});
}

if (isClusterExpandActivity(ocsCluster)) {
resourceActivities.push({
resource: ocsCluster,
timestamp: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont have to specify timestamp: null

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant you use status.lastUpdated as timestamp ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not any lastUpdated field in this type of CRD. Only creationtimestamp is present.

loader: () => Promise.resolve(ClusterExpandActivity),
});
}

return (
<OngoingActivityBody
loaded={progressResponse || progressError}
loaded={(progressResponse || progressError) && subscriptionsLoaded && storageClustersLoaded}
resourceActivities={resourceActivities}
prometheusActivities={prometheusActivities}
/>
);
},
);

export const ActivityCard: React.FC<{}> = React.memo(() => (
export const ActivityCard: React.FC = React.memo(() => (
<DashboardCard gradient>
<DashboardCardHeader>
<DashboardCardTitle>Activity</DashboardCardTitle>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import * as React from 'react';
import ActivityItem from '@console/shared/src/components/dashboard/activity-card/ActivityItem';
import { K8sResourceKind } from '@console/internal/module/k8s';

export const ClusterExpandActivity: React.FC = () => (
Copy link
Contributor Author

@afreen23 afreen23 Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reuse this too, but may be in future we want to modify the look and feel, hence keeping separate

afreen23 marked this conversation as resolved.
Show resolved Hide resolved
<ActivityItem>Expanding OCS Cluster</ActivityItem>
);

export const isClusterExpandActivity = (storageCluster: K8sResourceKind): boolean =>
storageCluster?.status?.phase === 'Expanding';
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import * as React from 'react';
import ActivityItem from '@console/shared/src/components/dashboard/activity-card/ActivityItem';
import { SubscriptionState, SubscriptionKind } from '@console/operator-lifecycle-manager';
import { getSubscriptionStatus } from '@console/operator-lifecycle-manager/src/status/csv-status';

export const isOCSUpgradeActivity = (subscription: SubscriptionKind): boolean =>
getSubscriptionStatus(subscription).status === SubscriptionState.SubscriptionStateUpgradePending;

export const OCSUpgradeActivity: React.FC = () => (
<ActivityItem>Upgrading OCS Operator</ActivityItem>
);
19 changes: 19 additions & 0 deletions frontend/packages/console-app/src/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import {
getPodStatusGroups,
getPVCStatusGroups,
} from '@console/shared/src/components/dashboard/inventory-card/utils';
import { OCSServiceModel } from '@console/ceph-storage-plugin/src/models';
import { isClusterExpandActivity } from '@console/ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/activity-card/cluster-expand-activity';
import {
fetchK8sHealth,
getK8sHealthState,
Expand Down Expand Up @@ -81,6 +83,23 @@ const plugin: Plugin<ConsumedExtensions> = [
required: FLAGS.CLUSTER_VERSION,
},
},
{
type: 'Dashboards/Overview/Activity/Resource',
properties: {
k8sResource: {
isList: true,
kind: referenceForModel(OCSServiceModel),
namespaced: false,
prop: 'storage-cluster',
},
isActivity: isClusterExpandActivity,
loader: () =>
import(
'@console/ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/activity-card/cluster-expand-activity' /* webpackChunkName: "ceph-storage-plugin" */
).then((m) => m.ClusterExpandActivity),
required: 'CEPH',
},
},
{
type: 'Dashboards/Overview/Health/URL',
properties: {
Expand Down