Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow long string container names to wrap and add spacing to checkbox rows #4032

Merged
merged 1 commit into from Jan 22, 2020
Merged

Allow long string container names to wrap and add spacing to checkbox rows #4032

merged 1 commit into from Jan 22, 2020

Conversation

sg00dwin
Copy link
Member

Before
Screen Shot 2020-01-20 at 11 30 31 AM

After
Screen Shot 2020-01-21 at 4 18 39 PM

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Jan 21, 2020
@sg00dwin sg00dwin force-pushed the add-storage-container-checkboxes branch from 3061d5f to 014d9e1 Compare January 22, 2020 16:16
rhamilto
rhamilto approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@sg00dwin sg00dwin changed the title All long string container names to wrap and add spacing to checkbox rows Allow long string container names to wrap and add spacing to checkbox rows Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4aae583 into openshift:master Jan 22, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
@sg00dwin sg00dwin deleted the add-storage-container-checkboxes branch January 27, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sg00dwin @openshift-ci-robot @rhamilto @spadgett @openshift-merge-robot