Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds decorator if any associated Workload pods has type warning #4052

Merged
merged 1 commit into from Jan 24, 2020
Merged

adds decorator if any associated Workload pods has type warning #4052

merged 1 commit into from Jan 24, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Jan 23, 2020 •
edited

adds decorator if any associated Workload pods have type warning and on click open sidebar

Tracks: https://issues.redhat.com/browse/ODC-2587

Gif :

ezgif com-video-to-gif (18)

cc: @openshift/team-devconsole-ux @serenamarie125

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jan 23, 2020
@invincibleJai invincibleJai force-pushed the fix-alerts-decorator branch 3 times, most recently from df77dd0 to 1f96b3a Compare January 23, 2020 13:22
@andrewballantyne
Copy link
Contributor

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2020
@serenamarie125
Copy link
Contributor

@invincibleJai for warning levels, please use the warning-triangle icon in orange (CSS var is --pf-c-alert--m-inline--m-warning__icon--Color).

Later when we have critical alerts, we would offer the ! in red

thanks!

@invincibleJai
Copy link
Member Author

@serenamarie125 thanks, have made the changes and updated gif as well PTAL.

Screenshot:

Screenshot 2020-01-23 at 8 52 38 PM

serenamarie125
serenamarie125 approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for making the change, this looks great!

vikram-raj
vikram-raj reviewed Jan 23, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
christianvogt
christianvogt reviewed Jan 24, 2020
View reviewed changes
frontend/packages/dev-console/src/components/topology/components/nodes/MonitoringDecorator.tsx Outdated
element
.getGraph()
.getController()
.fireEvent('selection', [element.getId()]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach. It'll work :)

Use the const for the selection event instead of a string

frontend/packages/dev-console/src/components/topology/components/nodes/MonitoringDecorator.tsx Outdated
x: number;
y: number;
element: Node;
onClickTab?: (name: string) => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to just onClick with no name param. The name is a const, use it in the connect down below.

frontend/packages/dev-console/src/components/topology/components/nodes/MonitoringDecorator.tsx Outdated
};

const mapDispatchToProps = (dispatch) => ({
onClickTab: (name) => dispatch(UIActions.selectOverviewDetailsTab(name)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  onClick: () => dispatch(UIActions.selectOverviewDetailsTab('Monitoring)),

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
vikram-raj
vikram-raj reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
vikram-raj
vikram-raj reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
vikram-raj
vikram-raj reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-kn, christianvogt, invincibleJai, serenamarie125, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3e08b3b into openshift:master Jan 24, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@christianvogt christianvogt christianvogt left review comments

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@abhi-kn abhi-kn abhi-kn approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

Assignees

@vikram-raj vikram-raj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@invincibleJai @andrewballantyne @serenamarie125 @christianvogt @openshift-bot @openshift-ci-robot @vikram-raj @abhi-kn @spadgett @openshift-merge-robot