Monitoring Dashboards: Fix tooltips and improve graph styling #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `QueryBrowser` tooltips expect the graph queries to be in Redux, so unfortunately to get these working, the dashboard will need to add the queries to Redux dynamically when the mouse moves over the graph. Improve the graph styling, especially for the graph legend.
openshift-ci-robot
added
size/L
openshift-ci-robot
added
the
approved
|
/test analyze |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QueryBrowsertooltips expect the graph queries to be in Redux, sounfortunately to get these working, the dashboard will need to add the
queries to Redux dynamically when the mouse moves over the graph.
Improve the graph styling, especially for the graph legend.
We should look for a cleaner way to pass the data to the tooltips, but that will be a larger change, so I think it makes sense to use this solution for 4.4.
More styling fixes are still to be done, including for the tooltip to stop it getting clipped at the edge of the dashboard card.