Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology: Add Helm Release selection and details side panel #4064

Merged
merged 1 commit into from Jan 25, 2020
Merged

Topology: Add Helm Release selection and details side panel #4064

merged 1 commit into from Jan 25, 2020

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Jan 24, 2020 •
edited

Addresses story https://issues.redhat.com/browse/ODC-2794

image

/cc @openshift/team-devconsole-ux

TODO:

  • Add resources tab once it is available

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console labels Jan 24, 2020
@andrewballantyne
Copy link
Contributor

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2020
@christianvogt
Copy link
Contributor

Errored out when opening the sidebar.
I used helm v3 and didn't get the labels so I manually added labels to the deployment and while the topology showed the helm grouping. Side bar resulted in this:
image

@jeff-phillips-18
Copy link
Member Author

Added a check and display an error if unable to find the resource.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2020
@christianvogt
Copy link
Contributor

/hold

waiting for #4065

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@spadgett
Copy link
Member

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 25, 2020
@jeff-phillips-18
Copy link
Member Author

@christianvogt Rebased, needs lgtm again

@andrewballantyne
Copy link
Contributor

/lgtm
/hold

This likely to follow the same issues as the rest of our PRs. https://coreos.slack.com/archives/CEKNRGF25/p1579962369129100

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor

/hold cancel
/retest

Looks like it's good to go again.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020
@andrewballantyne
Copy link
Contributor

/retest

@andrewballantyne
Copy link
Contributor

Bundle flake... but only so tiny amount... this test is quite annoying lol...

Main vendor bundle size: 2.48 MiB
FAILURE: Main vendor bundle is larger than the 2 MiB limit.

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9b61a4c into openshift:master Jan 25, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the helm-release-select branch December 2, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewballantyne andrewballantyne

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @andrewballantyne @christianvogt @spadgett @openshift-ci-robot @openshift-merge-robot