Bug 1796619: useSafetyFirst in rbac useAccessReview hook

[christianvogt]

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1796619

Swapped useState with useStafetyFirst in rbac useAccessReview hook because it has potential to call state function setAllowed after the component has unmounted.

Also updated the types for safety-first to avoid using as.

[openshift-ci-robot]

@christianvogt: This pull request references Bugzilla bug 1796619, which is invalid:

• expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1796619: useSafetyFirst in rbac useAccessReview hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianvogt]

/bugzilla refresh

[openshift-ci-robot]

@christianvogt: This pull request references Bugzilla bug 1796619, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@christianvogt: This pull request references Bugzilla bug 1796619, which is valid.

In response to this:

Bug 1796619: useSafetyFirst in rbac useAccessReview hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/lgtm

Tested the problem on the commit before yours and slowing down my network calls. This seems to address the unmount issue nicely.

[andrewballantyne]

/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@christianvogt: All pull requests linked via external trackers have merged. Bugzilla bug 1796619 has been moved to the MODIFIED state.

In response to this:

Bug 1796619: useSafetyFirst in rbac useAccessReview hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.