Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797576: Import from Image Stream - Should Default To Your Current Project #4079

Merged
merged 1 commit into from Feb 3, 2020
Merged

Bug 1797576: Import from Image Stream - Should Default To Your Current Project #4079

merged 1 commit into from Feb 3, 2020

Conversation

debsmita1
Copy link
Contributor

@debsmita1 debsmita1 commented Jan 27, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-2432

Analysis / Root cause:
The initial value of namespace under the imageStream property was set to empty string

Solution Description:
The initial value of namespace under the imageStream property is set to the active namespace value

Screenshots / Gifs for design review:
final_5e2f03f2db39810016a27981_521788

Unit test coverage report:
There are no unit tests for the deploy image components

Test setup:
NA

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2020
@debsmita1
Copy link
Contributor Author

/cc @karthikjeeyar

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/shared Related to console-shared labels Jan 27, 2020
christianvogt
christianvogt reviewed Jan 28, 2020
View reviewed changes
frontend/packages/dev-console/src/components/import/import-types.ts Outdated
@@ -16,6 +16,10 @@ export type ImageStreamState = {
hasCreateAccess: ImageStreamPayload;
selectedImageStream: ImageStreamPayload;
};
export interface ImageStreamNsDropdownProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component props should be co-located in the component file. Although I don't think you need to add props to fix this.

frontend/packages/dev-console/src/components/import/image-search/ImageStreamNsDropdown.tsx Outdated
@@ -80,6 +80,7 @@ const ImageStreamNsDropdown: React.FC = () => {
resources={getProjectResource()}
dataSelector={['metadata', 'name']}
onChange={onDropdownChange}
selectedKey={selectedNamespace}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceDropdownField already extracts the value from formik based on the given name prop.
This shouldn't be necessary. Only thing needed is to initialize the default value in formik.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2020
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@debsmita1
Copy link
Contributor Author

/retest

@debsmita1 debsmita1 changed the title default to current project in image stream Bug 1797576: Import from Image Stream - Should Default To Your Current Project Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1797576, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1797576: Import from Image Stream - Should Default To Your Current Project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@debsmita1
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1797576, which is valid. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9ab4391 into openshift:master Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: All pull requests linked via external trackers have merged. Bugzilla bug 1797576 has been moved to the MODIFIED state.

In response to this:

Bug 1797576: Import from Image Stream - Should Default To Your Current Project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@zherman0 zherman0 Awaiting requested review from zherman0

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@debsmita1 @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot