Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helm install issue #4086

Merged
merged 1 commit into from Jan 29, 2020
Merged

Fix helm install issue #4086

merged 1 commit into from Jan 29, 2020

Conversation

akashshinde
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jan 28, 2020
@akashshinde
Copy link
Contributor Author

/test e2e-gcp-console

@andrewballantyne
Copy link
Contributor

cc @rohitkrai03

@debsmita1
Copy link
Contributor

this fix works fine
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
rohitkrai03
rohitkrai03 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, debsmita1, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@andrewballantyne
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 545374d into openshift:master Jan 29, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@debsmita1 debsmita1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@akashshinde @andrewballantyne @debsmita1 @openshift-ci-robot @rohitkrai03 @spadgett @openshift-merge-robot