Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1801295: fix pod ring text while scaling up from 0 #4090

Merged
merged 1 commit into from Feb 18, 2020
Merged

Bug 1801295: fix pod ring text while scaling up from 0 #4090

merged 1 commit into from Feb 18, 2020

Conversation

nemesis09
Copy link
Contributor

@nemesis09 nemesis09 commented Jan 28, 2020 •
edited

This PR fixes https://issues.redhat.com/browse/ODC-2566

Analysis / Root cause:
Pod ring text shows two phrases when scaling from 0 to 1. Title is set to "scaled to 0" and Subtitle is set to "scaling to 1".

Solution description
checks status and spec for the workload are equal to set proper title for the case of scaling up from 0 to 1

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Screens:
pod-text

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/shared Related to console-shared labels Jan 28, 2020
sahil143
sahil143 suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemesis09 This method has become a bit complicated and is in need of unit tests.

@sahil143
Copy link
Contributor

@nemesis09 I can still see the wrong text on pods
Screenshot from 2020-01-29 19-17-10

@andrewballantyne
Copy link
Contributor

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 29, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jan 30, 2020
@nemesis09
Copy link
Contributor Author

@nemesis09 This method has become a bit complicated and is in need of unit tests.

There is no test in place for this util. Can we capture the tests for the complete util in a separate automation story?

@nemesis09
Copy link
Contributor Author

@nemesis09 I can still see the wrong text on pods
Screenshot from 2020-01-29 19-17-10

fixed. PTAL

@sahil143
Copy link
Contributor

@nemesis09 you don't have to right unit-tests for the whole file pod-ring-utils. Just write unit tests for the method(podRingLabel()) you made changes to.

@christianvogt
Copy link
Contributor

christianvogt commented Feb 3, 2020 •
edited

@nemesis09 original issue above seems to be fixed but we should log another issue regarding the spacing here:
image
image
image

cc @openshift/team-devconsole-ux

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2020
@nemesis09 nemesis09 changed the title fix pod ring text while scaling up from 0 Bug 1801295: fix pod ring text while scaling up from 0 Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@nemesis09: This pull request references Bugzilla bug 1801295, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1801295: fix pod ring text while scaling up from 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2020
@nemesis09
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@nemesis09: This pull request references Bugzilla bug 1801295, which is valid. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2020
@andrewballantyne
Copy link
Contributor

Out of the gate here, your tests fail @nemesis09

@andrewballantyne
Copy link
Contributor

@nemesis09 original issue above seems to be fixed but we should log another issue regarding the spacing here:
image
image
image

cc @openshift/team-devconsole-ux

@nemesis09 Did you address these issues? I can still reproduce the first screenshot just by putting something on Topology.

/retitle [WIP] Bug 1801295: fix pod ring text while scaling up from 0

This looks like it's still under work, putting a WIP flag on it.

@openshift-ci-robot openshift-ci-robot changed the title Bug 1801295: fix pod ring text while scaling up from 0 [WIP] Bug 1801295: fix pod ring text while scaling up from 0 Feb 12, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@nemesis09
Copy link
Contributor Author

@nemesis09 original issue above seems to be fixed but we should log another issue regarding the spacing here:
image
image
image
cc @openshift/team-devconsole-ux

@nemesis09 Did you address these issues? I can still reproduce the first screenshot just by putting something on Topology.

/retitle [WIP] Bug 1801295: fix pod ring text while scaling up from 0

This looks like it's still under work, putting a WIP flag on it.

this issue is being tracked in a separate ticket. https://issues.redhat.com/browse/ODC-3036

@andrewballantyne
Copy link
Contributor

this issue is being tracked in a separate ticket. https://issues.redhat.com/browse/ODC-3036

@nemesis09 ah indeed... fair enough. You just have a test to fix before we can give approvals.

@nemesis09 nemesis09 changed the title [WIP] Bug 1801295: fix pod ring text while scaling up from 0 Bug 1801295: fix pod ring text while scaling up from 0 Feb 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@nemesis09: This pull request references Bugzilla bug 1801295, which is valid.

In response to this:

Bug 1801295: fix pod ring text while scaling up from 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@openshift-ci-robot
Copy link
Contributor

@nemesis09: This pull request references Bugzilla bug 1801295, which is valid.

In response to this:

Bug 1801295: fix pod ring text while scaling up from 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@nemesis09: This pull request references Bugzilla bug 1801295, which is valid.

In response to this:

Bug 1801295: fix pod ring text while scaling up from 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nemesis09
Copy link
Contributor Author

fixed failing tests.

@nemesis09
Copy link
Contributor Author

/test images

@sahil143
Copy link
Contributor

@nemesis09 I dont think this issue is fixed. I can still see the double text on DC.
Screenshot from 2020-02-17 20-01-45

@nemesis09
Copy link
Contributor Author

nemesis09 commented Feb 17, 2020 •
edited

@nemesis09 I dont think this issue is fixed. I can still see the double text on DC.
Screenshot from 2020-02-17 20-01-45

I can't seem to reproduce this. I rebased with master but still failed to reproduce. Not sure where it is breaking.
pod-text-verify

@sahil143
Copy link
Contributor

I can't seem to reproduce this. I rebased with master but still failed to reproduce. Not sure where it is breaking.

Yeah, This is fixed. I guess PR was not pulled properly

sahil143
sahil143 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified changes locally.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, nemesis09, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 65e59a7 into openshift:master Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@nemesis09: All pull requests linked via external trackers have merged. Bugzilla bug 1801295 has been moved to the MODIFIED state.

In response to this:

Bug 1801295: fix pod ring text while scaling up from 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nemesis09 @sahil143 @andrewballantyne @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot