Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: update cluster utilization empty state message #4096

Conversation

spadgett
Copy link
Member

Align more closely with the other empty state messages on the page.

/assign @andybraren @rawagner

Before:

Screen Shot 2020-01-28 at 3 45 09 PM

After:

Screen Shot 2020-01-28 at 3 40 19 PM

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2020
@spadgett spadgett force-pushed the cluster-utilization-empty-state branch from a42d5a0 to 60d5625 Compare January 28, 2020 20:48
Align more closely with the other empty state messages on the page.
@spadgett spadgett force-pushed the cluster-utilization-empty-state branch from 60d5625 to 5f7776f Compare January 28, 2020 21:21
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2020
@spadgett
Copy link
Member Author

/test analyze

Copy link
Contributor

@andybraren andybraren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 👍

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5e0c9e4 into openshift:master Jan 29, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 4, 2020
@spadgett spadgett deleted the cluster-utilization-empty-state branch February 4, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants