Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1798101: Add test cases for VM filtering in VM list view #4097

Merged
merged 1 commit into from Feb 4, 2020
Merged

Bug 1798101: Add test cases for VM filtering in VM list view #4097

merged 1 commit into from Feb 4, 2020

Conversation

rhrazdil
Copy link

Added test coverage for VM filtering in VM list view implemented during our CNV UX Meetup.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Jan 28, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@yaacov
Copy link
Member

yaacov commented Feb 2, 2020

/retest

@rhrazdil
Copy link
Author

rhrazdil commented Feb 3, 2020

/test analyze

@yaacov
Copy link
Member

yaacov commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@rhrazdil rhrazdil changed the title Add test cases for VM filtering in VM list view Bug:1798101 Add test cases for VM filtering in VM list view Feb 4, 2020
@rhrazdil rhrazdil changed the title Bug:1798101 Add test cases for VM filtering in VM list view Bug 1798101: Add test cases for VM filtering in VM list view Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1798101, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798101: Add test cases for VM filtering in VM list view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@rhrazdil
Copy link
Author

rhrazdil commented Feb 4, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1798101, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020
atiratree
atiratree reviewed Feb 4, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.list-filtering.scenario.ts Outdated
it('Displays correct count of Other VMs', async () => {
await vm.waitForStatus(VM_STATUS.Importing);
await vm.navigateToListView();
const importingCount = await filterBoxCount('Importing');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this function return number already so we don't have to do the conversion each time we call it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2020
@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 92a63d4 into openshift:master Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: All pull requests linked via external trackers have merged. Bugzilla bug 1798101 has been moved to the MODIFIED state.

In response to this:

Bug 1798101: Add test cases for VM filtering in VM list view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree left review comments

@pcbailey pcbailey Awaiting requested review from pcbailey

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rhrazdil @yaacov @openshift-ci-robot @atiratree @openshift-bot @spadgett @openshift-merge-robot