Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loading missing ClusterVersionModel on Kubernetes #4103

Merged
merged 1 commit into from Jan 29, 2020
Merged

fix loading missing ClusterVersionModel on Kubernetes #4103

merged 1 commit into from Jan 29, 2020

Conversation

atiratree
Copy link
Member

#3899 added a notification drawer, but the resource ClusterVersionModel it is listing is not present on K8s, so the whole <AppContents /> doesn't get rendered.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Jan 29, 2020
@atiratree
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 29, 2020
@spadgett
Copy link
Member

@jcaianirh We shouldn't block the entire app contents from loading while waiting for ClusterVersion. It will make the console load feel slower (and I think it's why we see a black screen now on load). Let's look at addressing that in a separate PR.

spadgett
spadgett approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 10c9095 into openshift:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atiratree @spadgett @openshift-ci-robot @openshift-merge-robot @suomiy