Bug 1796538: Fix monitoring dashboard table columns #4131
Conversation
* Use target `refId` to correctly associate column styles to the data * Don't show hidden table columns
|
@spadgett: This pull request references Bugzilla bug 1796538, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@spadgett: This pull request references Bugzilla bug 1796538, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM, but will wait on @kyoto to give final approval. |
| @@ -112,15 +112,26 @@ const Table: React.FC<Props> = ({ panel, pollInterval, queries }) => { | |||
| if (error) { | |||
| return <ErrorAlert message={error} />; | |||
| } | |||
| // FIXME: It's a little unclear how to associate a column style with the data. This assumes the | |||
There was a problem hiding this comment.
It turns out we need to look at refId on panel.targets to associate the column style with the data.
| const label = _.first(Object.keys(metric)); | ||
| const tag = metric[label]; |
There was a problem hiding this comment.
This still isn't exactly correct, but works for the tables we currently show.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1796538 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
refIdto correctly associate column styles to the data/assign @rhamilto @kyoto
Before:
After: