Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1795713: Fix labels and Enable typeahead filter for name filter #4140

Merged
merged 1 commit into from Feb 15, 2020
Merged

Bug 1795713: Fix labels and Enable typeahead filter for name filter #4140

merged 1 commit into from Feb 15, 2020

Conversation

zherman0
Copy link
Member

@zherman0 zherman0 commented Jan 31, 2020 •
edited

Allows typeahead for the searchFilter name input instead of relying on enter press.
Peek 2020-02-12 20-21

Also adjusted labels to make UX better.
Ticket https://issues.redhat.com/browse/CONSOLE-2056 will be used to discuss this as well.
Screenshot_2020-02-12 Search · OKD(2)
Screenshot_2020-02-12 Search · OKD(3)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality labels Jan 31, 2020
@zherman0 zherman0 changed the title [WIP] Enable typeahead filter for searchFilter [WIP][POC] Enable typeahead filter for searchFilter Jan 31, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 12, 2020
@zherman0 zherman0 changed the title [WIP][POC] Enable typeahead filter for searchFilter Bug 1795713: Fix labels and Enable typeahead filter for name filter Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@zherman0: This pull request references Bugzilla bug 1795713, which is valid.

In response to this:

Bug 1795713: Fix labels and Enable typeahead filter for name filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@zherman0: This pull request references Bugzilla bug 1795713, which is valid.

In response to this:

Bug 1795713: Fix labels and Enable typeahead filter for name filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@zherman0: This pull request references Bugzilla bug 1795713, which is valid.

In response to this:

Bug 1795713: Fix labels and Enable typeahead filter for name filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zherman0
Copy link
Member Author

@benjaminapetersen - this is ready for review. Thanks.

@rhamilto
Copy link
Member

LGTM but should probably squash?

rhamilto
rhamilto approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@zherman0
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit abe5a08 into openshift:master Feb 15, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zherman0 @openshift-ci-robot @rhamilto @openshift-bot @spadgett @openshift-merge-robot