New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797486: Add icon next to pause/unpause events action #4148
Bug 1797486: Add icon next to pause/unpause events action #4148
Conversation
@rawagner: This pull request references Bugzilla bug 1797486, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/console-shared/src/components/dashboard/activity-card/ActivityBody.tsx
Outdated
Show resolved
Hide resolved
@rawagner: This pull request references Bugzilla bug 1797486, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bc1b1f5
to
9306ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
frontend/packages/console-shared/src/components/dashboard/activity-card/activity-card.scss
Outdated
Show resolved
Hide resolved
9306ef6
to
1bd6f8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is a nit and it seems to be an existing component, but the icon looks a little too close to the text. We might want to look at that as a follow on. I will defer to @andybraren though
Thanks @rawagner
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andybraren, rawagner, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1797486 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andybraren