Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1787028: fix runtime error creating PVC with no storage class #4165

Merged
merged 1 commit into from Feb 6, 2020
Merged

Bug 1787028: fix runtime error creating PVC with no storage class #4165

merged 1 commit into from Feb 6, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 3, 2020

@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1787028, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1787028: fix runtime error creating PVC with no storage class

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality labels Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@zherman0
Copy link
Member

zherman0 commented Feb 3, 2020

/retest

zherman0
zherman0 reviewed Feb 3, 2020
View reviewed changes
frontend/public/components/storage/create-pvc.tsx
@@ -155,29 +155,22 @@ export const CreatePVCForm: React.FC<CreatePVCFormProps> = (props) => {
};

const handleStorageClass = (updatedStorageClass) => {
const provisioner: string = updatedStorageClass?.provisioner || '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does optional chaining work in Firefox or IE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's suppored in TypeScript. The final JS won't have it.

@benjaminapetersen
Copy link
Contributor

/lgtm
/cherry-pick release-4.3

Since this was reported on 4.2.z

@openshift-cherrypick-robot
Copy link

@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick release-4.3

Since this was reported on 4.2.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2c3b26e into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1787028 has been moved to the MODIFIED state.

In response to this:

Bug 1787028: fix runtime error creating PVC with no storage class

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 6, 2020
Closed
@openshift-cherrypick-robot
Copy link

@benjaminapetersen: new pull request created: #4239

In response to this:

/lgtm
/cherry-pick release-4.3

Since this was reported on 4.2.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
@spadgett spadgett deleted the no-storage-class branch April 2, 2020 13:21
@spadgett spadgett mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zherman0 zherman0 zherman0 approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@benjaminapetersen benjaminapetersen

@zherman0 zherman0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spadgett @openshift-ci-robot @zherman0 @benjaminapetersen @openshift-cherrypick-robot @openshift-merge-robot