Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797327: Add top margin to the timed out fetching new data message #4174

Merged
merged 1 commit into from Feb 5, 2020
Merged

Bug 1797327: Add top margin to the timed out fetching new data message #4174

merged 1 commit into from Feb 5, 2020

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Feb 4, 2020

There are multiple different places we are using the StatusBox component which renders the "Timed out fetching new data" message:

  • After the horizontal navigation

Screenshot 2020-02-04 at 11 36 36

  • Resource sections

Screenshot 2020-02-04 at 11 40 17

  • When editing resources(eg. secrets)

Screenshot 2020-02-04 at 10 43 19

for that reason I propose to unify this by simply adding an additional margin-top.

Also removing orphaned .co-cluster-updates__component that we are not using anymore and also the .co-m-horizontal-nav which is not nesting the .co-m-timeout-error anymore
Screenshot 2020-02-04 at 11 57 27

Result:

Screenshot 2020-02-04 at 11 59 11

Screenshot 2020-02-04 at 11 59 17

Screenshot 2020-02-04 at 11 59 48

Screenshot 2020-02-04 at 11 59 59

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2020
@jhadvig jhadvig changed the title Add top margin to the timed out fetching new data message Bug 1797327: Add top margin to the timed out fetching new data message Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Bugzilla bug 1797327, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1797327: Add top margin to the timed out fetching new data message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2020
rhamilto
rhamilto reviewed Feb 4, 2020
View reviewed changes
frontend/public/components/utils/_status-box.scss Outdated
@@ -40,12 +40,9 @@
}

.co-m-timeout-error {
margin-top: 20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: alpha. Otherwise LGTM.

@jhadvig jhadvig assigned rhamilto and unassigned spadgett Feb 4, 2020
@jhadvig
Copy link
Member Author

jhadvig commented Feb 4, 2020

@rhamilto comment addressed. PTAL :)

rhamilto
rhamilto approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 865fc76 into openshift:master Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jhadvig: All pull requests linked via external trackers have merged. Bugzilla bug 1797327 has been moved to the MODIFIED state.

In response to this:

Bug 1797327: Add top margin to the timed out fetching new data message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jhadvig @openshift-ci-robot @openshift-bot @rhamilto @spadgett @openshift-merge-robot