Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1798006: VM details, Align href to page name #4176

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Bug 1798006: VM details, Align href to page name #4176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../packages/kubevirt-plugin/src/components/dashboards-page/vm-dashboard/vm-details-card.tsx
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ import {
import { VMDashboardContext } from '../../vms/vm-dashboard-context';
import { VirtualMachineModel } from '../../../models';
import { getVmiIpAddresses } from '../../../selectors/vmi/ip-address';
import { VM_DETAIL_OVERVIEW_HREF } from '../../../constants';
import { VM_DETAIL_DETAILS_HREF } from '../../../constants';
import { findVMPod } from '../../../selectors/pod/selectors';

export const VMDetailsCard: React.FC<VMDetailsCardProps> = () => {
Expand All @@ -37,7 +37,7 @@ export const VMDetailsCard: React.FC<VMDetailsCardProps> = () => {
VirtualMachineModel.kind,
name,
namespace,
)}/${VM_DETAIL_OVERVIEW_HREF}`;
)}/${VM_DETAIL_DETAILS_HREF}`;

return (
<DashboardCard>
Expand Down
4 changes: 2 additions & 2 deletions frontend/packages/kubevirt-plugin/src/components/vms/vm-details-page.tsx
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ import {
} from '../../models';
import { getResource } from '../../utils';
import {
VM_DETAIL_OVERVIEW_HREF,
VM_DETAIL_DETAILS_HREF,
VM_DETAIL_DISKS_HREF,
VM_DETAIL_NETWORKS_HREF,
VM_DETAIL_CONSOLES_HREF,
Expand Down Expand Up @@ -40,7 +40,7 @@ export const VirtualMachinesDetailsPage: React.FC<VirtualMachinesDetailsPageProp
};

const overviewPage = {
href: VM_DETAIL_OVERVIEW_HREF,
href: VM_DETAIL_DETAILS_HREF,
name: 'Details',
component: VMDetailsFirehose,
};
Expand Down
4 changes: 2 additions & 2 deletions frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ import {
} from '../../models';
import { getResource } from '../../utils';
import {
VM_DETAIL_OVERVIEW_HREF,
VM_DETAIL_DETAILS_HREF,
VM_DETAIL_DISKS_HREF,
VM_DETAIL_NETWORKS_HREF,
VM_DETAIL_CONSOLES_HREF,
Expand Down Expand Up @@ -44,7 +44,7 @@ export const VirtualMachinesInstanceDetailsPage: React.FC<VirtualMachinesInstanc
};

const overviewPage = {
href: VM_DETAIL_OVERVIEW_HREF,
href: VM_DETAIL_DETAILS_HREF,
name: 'Overview',
component: VMDetailsFirehose,
};
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/kubevirt-plugin/src/constants/vm/constants.ts
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ export const LABEL_USED_TEMPLATE_NAMESPACE = 'vm.kubevirt.io/template-namespace'

export const DEFAULT_RDP_PORT = 3389;

export const VM_DETAIL_OVERVIEW_HREF = 'overview';
export const VM_DETAIL_DETAILS_HREF = 'details';
export const VM_DETAIL_DISKS_HREF = 'disks';
export const VM_DETAIL_NETWORKS_HREF = 'nics';
export const VM_DETAIL_CONSOLES_HREF = 'consoles';
Expand Down