Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797681: Moved Event nav item from Advanced to Monitoring page as tab #4183

Merged
merged 2 commits into from Feb 6, 2020
Merged

Bug 1797681: Moved Event nav item from Advanced to Monitoring page as tab #4183

merged 2 commits into from Feb 6, 2020

Conversation

abhi-kn
Copy link
Contributor

@abhi-kn abhi-kn commented Feb 4, 2020

Fixes:
JIRA ID: https://issues.redhat.com/browse/ODC-2895
Bugzilla ID: https://bugzilla.redhat.com/show_bug.cgi?id=1797681

Analysis / Root cause:
In draft design, Events tab was not included as part of Monitoring page but later it has been added into final design & hence movement of Event page from Advanced to Monitoring page was missed.

Solution Description:

  • Event page has been moved under Monitoring page as a tab.
  • EventsList component in events.jsx has hardcoded Page title 'Events' but it's not required if rendered as a tab since tab name exists. Hence page title is now driven through props with default title as 'Events'.
  • PageHeading component is modified to include margin for title only when title exists

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
EventsTab

Unit test coverage report:
image

Test setup: Regular

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2020
@abhi-kn abhi-kn requested a review from spadgett February 4, 2020 15:05
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console labels Feb 4, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Feb 4, 2020

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 4, 2020
@abhi-kn abhi-kn changed the title Moved Event nav item from Advanced to Monitoring page as tab Bug 1797681 : Moved Event nav item from Advanced to Monitoring page as tab Feb 4, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Feb 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@abhi-kn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhi-kn abhi-kn changed the title Bug 1797681 : Moved Event nav item from Advanced to Monitoring page as tab Bug 1797681: Moved Event nav item from Advanced to Monitoring page as tab Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@abhi-kn: This pull request references Bugzilla bug 1797681, which is valid. The bug has been moved to the POST state.

In response to this:

Bug 1797681: Moved Event nav item from Advanced to Monitoring page as tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2020
christianvogt
christianvogt reviewed Feb 5, 2020
View reviewed changes
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/utils/headings.tsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Feb 5, 2020

/retest

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@christianvogt
Copy link
Contributor

/test e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-kn, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Feb 6, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit db9c49f into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@abhi-kn: All pull requests linked via external trackers have merged. Bugzilla bug 1797681 has been moved to the MODIFIED state.

In response to this:

Bug 1797681: Moved Event nav item from Advanced to Monitoring page as tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 6, 2020
@debsmita1 debsmita1 mentioned this pull request Feb 10, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@spadgett spadgett Awaiting requested review from spadgett

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abhi-kn @openshift-ci-robot @christianvogt @openshift-bot @spadgett @openshift-merge-robot