Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug-1794844: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource #4191

Merged
merged 1 commit into from Feb 25, 2020
Merged

Bug-1794844: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource #4191

merged 1 commit into from Feb 25, 2020

Conversation

cyril-ui-developer
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/olm Related to OLM labels Feb 4, 2020
@cyril-ui-developer cyril-ui-developer changed the title Bug-1794844: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Bug-1794844 & 1797769: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Feb 5, 2020
@cyril-ui-developer cyril-ui-developer changed the title Bug-1794844 & 1797769: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Bug-1794844 & 1797766: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Feb 6, 2020
@benjaminapetersen
Copy link
Contributor

I think we may have to split this up into 2 PRs for the 2 bugs in order for the bot to let us merge.

@cyril-ui-developer cyril-ui-developer changed the title Bug-1794844 & 1797766: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Bug-1794844: specDescriptor - "resourceRequirements" - Missing 'Limits and Requests' fields for "Storage (ephemeral storage)" resource Feb 6, 2020
TheRealJon
TheRealJon approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for code quality and logic.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
benjaminapetersen
benjaminapetersen approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@benjaminapetersen benjaminapetersen added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, cyril-ui-developer, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Feb 24, 2020 •
edited

/cherry-pick release-4.4
https://bugzilla.redhat.com/show_bug.cgi?id=1806722

@openshift-cherrypick-robot
Copy link

@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7bac664 into openshift:master Feb 25, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2020
Merged
@openshift-cherrypick-robot
Copy link

@benjaminapetersen: new pull request created: #4457

In response to this:

/cherry-pick release-4.4
https://bugzilla.redhat.com/show_bug.cgi?id=1806722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@TheRealJon TheRealJon TheRealJon approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@benjaminapetersen benjaminapetersen

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cyril-ui-developer @benjaminapetersen @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @TheRealJon @spadgett @openshift-merge-robot