Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796664: Change link to external link #4193

Merged
merged 1 commit into from Feb 5, 2020
Merged

Bug 1796664: Change link to external link #4193

merged 1 commit into from Feb 5, 2020

Conversation

rebeccaalpert
Copy link
Contributor

Changed Marketplace link in Operator details modal to external link.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1796664.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2020
@rebeccaalpert rebeccaalpert changed the title frontend: Change link to external link Bug 1796664: Change link to external link Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: This pull request references Bugzilla bug 1796664, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796664: Change link to external link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/olm Related to OLM labels Feb 4, 2020
@rebeccaalpert
Copy link
Contributor Author

/retest

@spadgett
Copy link
Member

spadgett commented Feb 5, 2020

/assign @rhamilto

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

Please add a screenshot. I'm pretty sure this is going to result in two external link icons.

@rebeccaalpert
Copy link
Contributor Author

Nah, looks ok to me.

Screen Shot 2020-02-05 at 1 41 13 PM

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020 •
edited

So it looks like the .pf-c-button::after styles are overriding the .co-external-link:after styles preventing a double icon.

Screen Shot 2020-02-05 at 1 43 17 PM

We should probably look at fixing this in a follow on so they are compatible.

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/approved

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/retest

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/lgtm cancel

please squash.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 5, 2020
@rebeccaalpert
frontend: Change link to external link
a4d59ea 
Changed Marketplace link in Operator details modal to external link.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1796664
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@rebeccaalpert
Copy link
Contributor Author

Squashed.

@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/approved

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@rhamilto
Copy link
Member

rhamilto commented Feb 5, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cc6124f into openshift:master Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@rebeccaalpert: All pull requests linked via external trackers have merged. Bugzilla bug 1796664 has been moved to the MODIFIED state.

In response to this:

Bug 1796664: Change link to external link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett Awaiting requested review from spadgett

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rebeccaalpert @openshift-ci-robot @spadgett @rhamilto @openshift-bot @openshift-merge-robot