Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1798451: Fix VM Events card actions layout #4202

Merged

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Feb 5, 2020

Before
Screenshot from 2020-02-05 12-52-42

After
Screenshot from 2020-02-05 14-28-20

/assign @mareklibra

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1798451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1798451: Fix VM Events card actions layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2020
@mareklibra
Copy link
Contributor

To my eye, the boundary between these two actions (and especially the related icon) is not clear.

@andybraren , wdyt?

@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1798451, which is valid.

In response to this:

Bug 1798451: Fix VM Events card actions layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andybraren
Copy link
Contributor

To my eye, the boundary between these two actions (and especially the related icon) is not clear.

@andybraren , wdyt?

The new md spacer lgtm (the image in the original comment has been updated) 👍.

@mareklibra
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 41f1212 into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: All pull requests linked via external trackers have merged. Bugzilla bug 1798451 has been moved to the MODIFIED state.

In response to this:

Bug 1798451: Fix VM Events card actions layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants