Bug 1798827: Monitoring Dashboards: Limit bar chart height #4219
Conversation
|
@kyoto: This pull request references Bugzilla bug 1798827, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/retest |
| @@ -24,6 +28,8 @@ | |||
| .monitoring-dashboards__panel { | |||
| height: calc(100% - 20px); | |||
| margin: 0 -5px 20px -5px; | |||
| max-height: 400px; | |||
There was a problem hiding this comment.
Will this add a scrollbar to some tables? That might be a little awkward since we have paging. I'd think we either want to scroll or page.
There was a problem hiding this comment.
Thanks @spadgett, good point.
I changed the PR so that max-height only applies to panels with gradient set to true.
| return ( | ||
| <div className={`col-xs-12 col-sm-${colSpanSm} col-lg-${colSpan}`}> | ||
| <DashboardCard className="monitoring-dashboards__panel"> | ||
| <DashboardCard className="monitoring-dashboards__panel" gradient={isBarChart}> |
There was a problem hiding this comment.
Any reason not to use the gradient for any scrolling panel? I assume you only see the effect if there is content hidden.
There was a problem hiding this comment.
The gradient effect is actually added to the bottom of the panel even if there is no hidden content.
The bar chart has enough space at the bottom for the last bar to not be covered by the gradient.
kyoto
force-pushed
the
monitoring-dashboards-fix-panel-heights
branch
from
b49b757
to
24ea2b3
Compare
|
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift-ci-robot
added
the
needs-rebase
Uses a gradient at the bottom of the card to indicate it is scrollable.
kyoto
force-pushed
the
monitoring-dashboards-fix-panel-heights
branch
from
24ea2b3
to
085250c
Compare
openshift-ci-robot
removed
lgtm
|
Rebased |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1798827 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Uses a gradient at the bottom of the card to indicate it is scrollable.