Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796116: fix duplicate badge on dev console list pages #4256

Merged
merged 1 commit into from Feb 12, 2020
Merged

Bug 1796116: fix duplicate badge on dev console list pages #4256

merged 1 commit into from Feb 12, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 7, 2020

@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1796116, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796116: fix duplicate badge on dev console list pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Feb 7, 2020
andrewballantyne
andrewballantyne approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny nit.

frontend/public/components/factory/list-page.jsx Outdated Show resolved Hide resolved
@abhi-kn abhi-kn mentioned this pull request Feb 10, 2020
Merged
4 tasks
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Feb 11, 2020
@spadgett
Copy link
Member Author

@andrewballantyne updated, another look?

spadgett
spadgett commented Feb 11, 2020
View reviewed changes
frontend/packages/dev-console/src/components/projects/ProjectListPage.tsx
</PageHeading>
<hr className="odc-project-list-page__section-border" />
<ListPage
{...props}
{...listPageProps}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This avoids the whole problem by simply not passing the badge prop through to the ProjectList when it shouldn't be displayed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the beauty of React. Nice solution @spadgett - I'll do a quick once over in a few moments after my current review but this looks like an elegant solution.

andrewballantyne
andrewballantyne approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Often the best solutions are the simplest. Nice catch Sam.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f50cab2 into openshift:master Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1796116 has been moved to the MODIFIED state.

In response to this:

Bug 1796116: fix duplicate badge on dev console list pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the fix-search-badge branch February 12, 2020 01:38
@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @andrewballantyne @openshift-merge-robot