Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page #4257

Merged
merged 1 commit into from Feb 11, 2020
Merged

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page #4257

merged 1 commit into from Feb 11, 2020

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Feb 7, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1796521, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality labels Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1796521, which is valid.

In response to this:

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaianirh
Copy link
Member Author

/test analyze

1 similar comment
@jcaianirh
Copy link
Member Author

/test analyze

@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1796521, which is valid.

In response to this:

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtaylor113
dtaylor113 requested changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, wonder if the alert message could be "Check OpenShift Documentation..." and include an external link to appropriate documentation such as: https://prometheus.io/docs/alerting/configuration/#configuration
Also, for 4.4 there is already a created default receiver named 'null', what we'd like is for users to configure the 'null' receiver, link will goto alertmanager configure page where the 'null' receiver will have an 'Configure' link. So, top alert link should be 'Configure Default Receiver' instead of 'Create Receiver'.
For 4.5, there will be three initial recievers 'Watchdog (formally named 'null'), Critical and Default.

@jcaianirh
Copy link
Member Author

@dtaylor113 thanks for the input. I was coding to the design but maybe there’s some room to change what was previously discussed. @cshinn what do you think?

@cshinn
Copy link

cshinn commented Feb 10, 2020

Hi, wonder if the alert message could be "Check OpenShift Documentation..." and include an external link to appropriate documentation such as: https://prometheus.io/docs/alerting/configuration/#configuration
Also, for 4.4 there is already a created default receiver named 'null', what we'd like is for users to configure the 'null' receiver, link will goto alertmanager configure page where the 'null' receiver will have an 'Configure' link. So, top alert link should be 'Configure Default Receiver' instead of 'Create Receiver'.
For 4.5, there will be three initial recievers 'Watchdog (formally named 'null'), Critical and Default.

@dtaylor113 I talked it over with @jcaianirh and we're going to go with "Configure receivers" for the button text. I agree that including a link directly to the documentation would be cool, but we want people to end up on the configuration page and more things to click on might distract from that. I think the work you did on that page makes configuring pretty straightforward and the docs are pretty easy to find by googling, so I don't think linking them is as important as the configure action.

@dtaylor113
Copy link
Contributor

dtaylor113 commented Feb 10, 2020 •
edited

@dtaylor113 I talked it over with @jcaianirh and we're going to go with "Configure receivers"

Ok works for me, thanks :-)

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2020
dtaylor113
dtaylor113 approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -thanks

spadgett
spadgett approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcaianirh. lgtm, please squash

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@jcaianirh
Copy link
Member Author

@spadgett squashed thanks!

spadgett
spadgett approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e57533e into openshift:master Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: All pull requests linked via external trackers have merged. Bugzilla bug 1796521 has been moved to the MODIFIED state.

In response to this:

Bug 1796521: Notification drawer alert to setup monitoring directs user to config page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jcaianirh @openshift-ci-robot @cshinn @dtaylor113 @openshift-bot @spadgett @openshift-merge-robot