Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1800867: don't repeat "Uninstall Operator" text in modal #4259

Merged
merged 1 commit into from Feb 17, 2020
Merged

Bug 1800867: don't repeat "Uninstall Operator" text in modal #4259

merged 1 commit into from Feb 17, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 8, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1800867

@itsptk Opinion? We could also leave the title "Uninstall Operator" and put the name in the message. I notice some other inconsistencies too (like using the question mark in one place and not the other).

/assign @itsptk

Before:

Screen Shot 2020-02-08 at 9 15 22 AM

After:

Screen Shot 2020-02-08 at 9 16 48 AM

For reference, here is the delete project modal:

Screen Shot 2020-02-08 at 9 15 10 AM

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 8, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1800867, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1800867: don't repeat "Uninstall Operator" text in modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2020
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Feb 8, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2020
@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2020

OK, I've noticed this is an issue for the normal delete modal, too. I've attempted to make these more consistent.

Before:

Screen Shot 2020-02-08 at 10 23 50 AM

Screen Shot 2020-02-08 at 10 24 00 AM

Screen Shot 2020-02-08 at 10 24 14 AM

After:

Screen Shot 2020-02-08 at 10 20 44 AM

Screen Shot 2020-02-08 at 10 12 20 AM

Screen Shot 2020-02-08 at 10 12 07 AM

@itsptk
Copy link

itsptk commented Feb 10, 2020

@spadgett I think this is all on the right track, thanks for making this consistent across the other dialogs as well.

A guideline exists for PF4 "Confirm a destructive action" with a modal: https://www.patternfly.org/v4/design-guidelines/usage-and-behavior/modal
image
Any chance the icon could move to the top line to be in line with that? Let's keep the question mark on the title.

Also, any chance of making the buttons left aligned or including the close "X" with this?

@spadgett
Copy link
Member Author

I'll look at moving the icon.

I'd rather track the button alignment separately since that impacts every modal. @sg00dwin @rhamilto fyi

@itsptk
Copy link

itsptk commented Feb 10, 2020

@spadgett Ok after asking some designers they mentioned the button placement (left/right) has been an ongoing thing, so I agree probably not worth addressing here.

Would the close "X" button be doable here or more of a sweeping change?

@spadgett
Copy link
Member Author

I'd say we track the x separately as well since it's an issue with all dialogs if you agree.

@itsptk
Copy link

itsptk commented Feb 10, 2020

Sounds good to me, thanks Sam.

@spadgett spadgett changed the title Bug 1800867: don't repeat "Uninstall Operator" text in modal [WIP] Bug 1800867: don't repeat "Uninstall Operator" text in modal Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2020
@spadgett
Copy link
Member Author

/assign @rhamilto

I've found some others I've updated. Here are the screenshots:

Screen Shot 2020-02-10 at 12 47 03 PM
Screen Shot 2020-02-10 at 12 46 54 PM
Screen Shot 2020-02-10 at 12 39 20 PM
Screen Shot 2020-02-10 at 12 38 33 PM
Screen Shot 2020-02-10 at 12 38 17 PM

@spadgett spadgett changed the title [WIP] Bug 1800867: don't repeat "Uninstall Operator" text in modal Bug 1800867: don't repeat "Uninstall Operator" text in modal Feb 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2020
rhamilto
rhamilto approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

/hold
needs test updates

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020
@rhamilto rhamilto mentioned this pull request Feb 14, 2020
Merged
4 tasks
@spadgett
Bug 1800867: Improve consistency between delete modals
de78fde 
Improve the consistency in layout and wording between the various delete
modals, such as delete resource, delete project, and uninstall operator.

https://bugzilla.redhat.com/show_bug.cgi?id=1800867
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@spadgett
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020
@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 234ec55 into openshift:master Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1800867 has been moved to the MODIFIED state.

In response to this:

Bug 1800867: don't repeat "Uninstall Operator" text in modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the uninstall-operator-dialog branch February 17, 2020 22:43
@spadgett spadgett added this to the v4.4 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@rhamilto rhamilto

@itsptk itsptk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spadgett @openshift-ci-robot @itsptk @openshift-bot @rhamilto @openshift-merge-robot